linux-kernel - Re: [PATCH 1/5] dt-bindings: iio: imu: Add ICM-20948

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f39bf664-1c06-4ef9-a8db-65b53b5e5270@kernel.org>
Date: Sun, 31 Aug 2025 14:57:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bharadwaj Raju <bharadwaj.raju777@...il.com>,
 Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, shuah@...nel.org,
 linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH 1/5] dt-bindings: iio: imu: Add ICM-20948

On 30/08/2025 20:42, Bharadwaj Raju wrote:
> +description: |
> +  9-axis motion-tracking device that combines a 3-axis gyroscope, 3-axis
> +  accelerometer, and a 3-axis magnetometer.
> +
> +  https://invensense.tdk.com/wp-content/uploads/2024/03/DS-000189-ICM-20948-v1.6.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - invensense,icm20948
> +

That's pretty incomplete. See existing invense bindings. Explain in
commit msg how this is different than existing devices.

> +  reg:
> +    maxItems: 1
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      icm20948 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).


> +        compatible = "invensense,icm20948";
> +        reg = <0x69>;
> +      }
> +    }
> 


Best regards,
Krzysztof