linux-kernel - Re: [PATCH 1/1] Drivers: hv: Simplify data structures for VMBus channel close message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMvTesBGma=mXDvY=3aqp0k3A3LQt1y7gnMLrD4CqJ1WW1dPSA@mail.gmail.com>
Date: Mon, 1 Sep 2025 01:56:17 +0800
From: Tianyu Lan <ltykernel@...il.com>
To: mhklinux@...look.com
Cc: haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com, 
	kys@...rosoft.com, linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org, 
	gustavoars@...nel.org
Subject: Re: [PATCH 1/1] Drivers: hv: Simplify data structures for VMBus
 channel close message

On Mon, Sep 1, 2025 at 12:06 AM <mhkelley58@...il.com> wrote:
>
> From: Michael Kelley <mhklinux@...look.com>
>
> struct vmbus_close_msg is used for sending the VMBus channel close
> message. It contains a struct vmbus_channel_msginfo, which has a
> flex array member at the end. The latter's presence in the middle
> of struct vmbus_close_msg causes warnings when built with
> -Wflex-array-member-not-at-end.
>
> But the struct vmbus_channel_msginfo is unused because the Hyper-V host
> does not send a response to the channel close message. So remove the
> struct vmbus_channel_msginfo. Then, since the only remaining field is
> struct vmbus_channel_close_channel, also remove the containing struct
> vmbus_close_msg and directly use struct vmbus_channel_close_channel.
> Besides eliminating unnecessary complexity, these changes resolve the
> -Wflex-array-member-not-at-end warnings.
>
> Signed-off-by: Michael Kelley <mhklinux@...look.com>
> ---

Reviewed-by: Tianyu Lan <tiala@...rosoft.com>




-- 
Thanks
Tianyu Lan