linux-kernel - Re: [PATCH v3 1/3] dt-bindings: spmi: Add Apple A11 and T2 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09e1a345-21d5-4ff7-831c-755e00898a45@kernel.org>
Date: Sun, 31 Aug 2025 20:23:03 +0200
From: Sven Peter <sven@...nel.org>
To: Nick Chan <towinchenmi@...il.com>, Janne Grunau <j@...nau.net>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa <neal@...pa.dev>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sasha Finkelstein <fnkl.kernel@...il.com>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spmi: Add Apple A11 and T2 compatible

On 29.08.25 10:47, Nick Chan wrote:
> The SPMI bus found on Apple A11 and T2 SoCs are compatible with the
> existing driver for t8103's spmi so add their compatibles.
> 
> Acked-by: Rob Herring (Arm) <robh@...nel.org>
> Reviewed-by: Sven Peter <sven@...nel.org>

Please drops those tags if you make a significant change like you did 
here between v2 and v3.

> Signed-off-by: Nick Chan <towinchenmi@...il.com>
> ---

[...]

> @@ -27,7 +30,6 @@ properties:
>                 - apple,t6000-spmi
>                 - apple,t8112-spmi
>             - const: apple,spmi
> -

Why are you removing the blank line here?


Sven