linux-kernel - Re: [PATCH 5/5] iio: imu: icm20948: add runtime power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33ca2805-aa52-4b27-9fa9-ec582b7129f2@web.de>
Date: Sun, 31 Aug 2025 21:23:08 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Bharadwaj Raju <bharadwaj.raju777@...il.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Cc: LKML <linux-kernel@...r.kernel.org>, Andy Shevchenko <andy@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, David Lechner <dlechner@...libre.com>,
 Jonathan Cameron <jic23@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Nuno Sá <nuno.sa@...log.com>,
 Rob Herring <robh@...nel.org>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH 5/5] iio: imu: icm20948: add runtime power management
 support

…
> @@ -24,17 +24,24 @@ static const struct iio_chan_spec
>  static int inv_icm20948_temp_read_sensor(struct inv_icm20948_state *state,
>  					 s16 *temp)
>  {
> -	guard(mutex)(&state->lock);
> +	int ret;
> +
> +	pm_runtime_get_sync(state->dev);
> +	mutex_lock(&state->lock);
>  
>  	__be16 raw;
> -	int ret = regmap_bulk_read(state->regmap, INV_ICM20948_REG_TEMP_DATA,
> +	ret = regmap_bulk_read(state->regmap, INV_ICM20948_REG_TEMP_DATA,
>  				   &raw, sizeof(raw));
>  	if (ret)
> -		return ret;
> +		goto out;
>  
>  	*temp = __be16_to_cpu(raw);
> +	ret = 0;
>  
> -	return 0;
> +out:
> +	mutex_unlock(&state->lock);
> +	pm_runtime_put_autosuspend(state->dev);
> +	return ret;
>  }
…

Does anything hinder you with the continued application of scope-based resource management
for such a function implementation?

Regards,
Markus