linux-kernel - Re: [PATCH] mfd: max77705: rework interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33eb49c4-aacf-46ec-a7c2-94ec8cba0243@kernel.org>
Date: Sun, 31 Aug 2025 10:29:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dzmitry Sankouski <dsankouski@...il.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Lee Jones <lee@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max77705: rework interrupts

On 31/08/2025 00:13, Dzmitry Sankouski wrote:
> Current implementation describes only MFD's own topsys interrupts.
> However, max77705 has a register which indicates interrupt source, i.e.
> it acts as an interrupt controller. There's 4 interrupt sources in
> max77705: topsys, charger, fuelgauge, usb type-c manager.
> 
> Setup max77705 MFD parent as an interrupt controller. Leave topsys
> interrupts unregistered, because currently unused.

Then you should remove them from the driver.
> 
> Fixes: c8d50f029748 ("mfd: Add new driver for MAX77705 PMIC")
> 

No blank lines between the tags.


> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> ---
> Max77705 has a register, which indicates, who is triggering irq. There
> may be 4 irq sources in max77705: charger, fuelgauge, usb type-c
> manager ic, and so-called 'topsys'. Hence, max77705 mfd parent device is
> an interrupt controller. This series implements interrupt controller in
> max77705 mfd.



Best regards,
Krzysztof