linux-kernel - Re: [PATCH] fscrypt: optimize fscrypt_base64url

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38753d95-8503-4b72-9590-cb129aa49a41@t-8ch.de>
Date: Sun, 31 Aug 2025 11:20:23 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Guan-Chun Wu <409411716@....tku.edu.tw>
Cc: ebiggers@...nel.org, tytso@....edu, jaegeuk@...nel.org, 
	linux-fscrypt@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fscrypt: optimize fscrypt_base64url_encode() with block
 processing

On 2025-08-30 21:28:32+0800, Guan-Chun Wu wrote:
> Previously, fscrypt_base64url_encode() processed input one byte at a
> time, using a bitstream, accumulating bits and emitting characters when
> 6 bits were available. This was correct but added extra computation.

Can't the custom base64 implementations in fs/ not pass a custom table
and padding to the generic algorithm in lib/? Then we only need to maintain
this code once.


Thomas