linux-kernel - Re: [PATCH net] net: ethernet: ti: am65-cpsw-nuss: Fix null pointer dereference for ndev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250901132232.GA15473@horms.kernel.org>
Date: Mon, 1 Sep 2025 14:22:32 +0100
From: Simon Horman <horms@...nel.org>
To: Chintan Vankar <c-vankar@...com>
Cc: Michael Walle <mwalle@...nel.org>, Roger Quadros <rogerq@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew+netdev@...n.ch>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, nm@...com, s-vadapalli@...com,
	danishanwar@...com
Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw-nuss: Fix null pointer
 dereference for ndev

On Fri, Aug 29, 2025 at 05:40:51PM +0530, Chintan Vankar wrote:
> From: Nishanth Menon <nm@...com>
> 
> In the TX completion packet stage of TI SoCs with CPSW2G instance, which
> has single external ethernet port, ndev is accessed without being
> initialized if no TX packets have been processed. It results into null
> pointer dereference, causing kernel to crash. Fix this by having a check
> on the number of TX packets which have been processed.
> 
> Fixes: 9a369ae3d143 ("net: ethernet: ti: am65-cpsw: remove am65_cpsw_nuss_tx_compl_packets_2g()")
> Signed-off-by: Nishanth Menon <nm@...com>
> Signed-off-by: Chintan Vankar <c-vankar@...com>

Thanks,

I see that prior to the cited commit, the code now
in the condition updated by this patch was executed
in the loop that now precedes the conditional. And in
the flow before the cited patch ndev was always set
in the loop before the code in question runs.

Reviewed-by: Simon Horman <horms@...nel.org>