linux-kernel - Re: [PATCH v4] net/core: Replace offensive comment in skbuff.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <willemdebruijn.kernel.1137e554f806b@gmail.com>
Date: Mon, 01 Sep 2025 09:32:17 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: mysteryli <m13940358460@....com>, 
 "David S . Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>
Cc: Andrew Lunn <andrew@...n.ch>, 
 Simon Horman <horms@...nel.org>, 
 Willem de Bruijn <willemb@...gle.com>, 
 Mina Almasry <almasrymina@...gle.com>, 
 Jason Xing <kerneljasonxing@...il.com>, 
 Michal Luczaj <mhal@...x.co>, 
 Alexander Lobakin <aleksander.lobakin@...el.com>, 
 Eric Biggers <ebiggers@...gle.com>, 
 netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 Mystery Li <929916200@...com>, 
 Mystery Li <m13940358460@....com>
Subject: Re: [PATCH v4] net/core: Replace offensive comment in skbuff.c

mysteryli wrote:
> From: Mystery Li <929916200@...com>
> 
> The original comment contained profanity to express the frustration of
> dealing with a complex and resource-constrained code path. While the
> sentiment is understandable, the language is unprofessional and
> unnecessary.
> Replace it with a more neutral and descriptive comment that maintains
> the original technical context and conveys the difficulty of the
> situation without the use of offensive language.
> Indeed, I do not believe this will offend any particular individual or group.
> Nonetheless, it is advisable to revise any commit that appears overly emotional or rude.
> 
> Signed-off-by: "Mystery Li" <m13940358460@....com>

You ignored the main feedback to patch v1 about invalid signed-off.

And for some reason sent the same patch again as v2 and v4.

In general old comments are left as is, even those that would perhaps
be written differently today.