linux-kernel - Re: [PATCH v2 4/4] can: rcar_canfd: Simplify data bit rate config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUNZag2kf9Dq_sv++6DtU-2tWAgQa5vi36duBx77=a+KA@mail.gmail.com>
Date: Mon, 1 Sep 2025 15:42:21 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Biju <biju.das.au@...il.com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	Magnus Damm <magnus.damm@...il.com>, Biju Das <biju.das.jz@...renesas.com>, 
	linux-can@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 4/4] can: rcar_canfd: Simplify data bit rate config

Hi Biju,

On Thu, 21 Aug 2025 at 16:14, Biju <biju.das.au@...il.com> wrote:
> From: Biju Das <biju.das.jz@...renesas.com>
>
> Introduce rcar_canfd_compute_data_bit_rate_cfg() for simplifying data bit
> rate configuration by replacing function-like macros.
>
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---
> v1->v2:
>  * Split from patch#3 for computing data bit rate config separate.
>    separate.
>  * Replaced RCANFD_DCFG_DBRP->RCANFD_DCFG_DBRP_MASK and used FIELD_PREP to
>    extract value.

Thanks for your patch!

For correctness:
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

But I have the same comments as for "[PATCH v2 3/4] can: rcar_canfd:
Simplify nominal bit rate config".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds