linux-kernel - Re: [PATCH v5 02/12] arch: export set_direct_map_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250901134659.32171-1-roypat@amazon.co.uk>
Date: Mon, 1 Sep 2025 13:47:00 +0000
From: "Roy, Patrick" <roypat@...zon.co.uk>
To: "tabba@...gle.com" <tabba@...gle.com>
CC: "ackerleytng@...gle.com" <ackerleytng@...gle.com>, "david@...hat.com"
	<david@...hat.com>, "Manwaring, Derek" <derekmn@...zon.com>, "Thomson, Jack"
	<jackabt@...zon.co.uk>, "Kalyazin, Nikita" <kalyazin@...zon.co.uk>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "kvmarm@...ts.linux.dev"
	<kvmarm@...ts.linux.dev>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "Roy, Patrick"
	<roypat@...zon.co.uk>, "rppt@...nel.org" <rppt@...nel.org>,
	"seanjc@...gle.com" <seanjc@...gle.com>, "vbabka@...e.cz" <vbabka@...e.cz>,
	"will@...nel.org" <will@...nel.org>, "Cali, Marco" <xmarcalx@...zon.co.uk>
Subject: Re: [PATCH v5 02/12] arch: export set_direct_map_valid_noflush to KVM
 module

Hi Fuad!

On Thu, 2025-08-28 at 11:07 +0100, Fuad Tabba wrote:
>> diff --git a/arch/loongarch/mm/pageattr.c b/arch/loongarch/mm/pageattr.c
>> index f5e910b68229..d076bfd3fcbf 100644
>> --- a/arch/loongarch/mm/pageattr.c
>> +++ b/arch/loongarch/mm/pageattr.c
>> @@ -217,6 +217,7 @@ int set_direct_map_invalid_noflush(struct page *page)
>>
>>         return __set_memory(addr, 1, __pgprot(0), __pgprot(_PAGE_PRESENT | _PAGE_VALID));
>>  }
>> +EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm");
> 
> This should be after 'set_direct_map_valid_noflush', not 'invalid'.
> 
> With that fixed:
> 
> Reviewed-by: Fuad Tabba <tabba@...gle.com>

Ah, yes, good catch, thanks!

Best,
Patrick