linux-kernel - Re: [PATCH] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLWs-z_bYmuld3q9@quark2.heme.sigxcpu.org>
Date: Mon, 1 Sep 2025 16:26:03 +0200
From: Guido Günther <agx@...xcpu.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Jessica Zhang <jessica.zhang@....qualcomm.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Casey Connolly <casey.connolly@...aro.org>,
	phone-devel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: visionox-rm69299: Fix clock frequency for
 SHIFT6mq

Hi Neil,

On Mon, Sep 01, 2025 at 02:24:48PM +0200, Neil Armstrong wrote:
> On 30/08/2025 17:29, Guido Günther wrote:
> > Make the clock frequency match what the sdm845 downstream kernel
> > uses. Otherwise we're seeing timeouts like
> > 
> > ```
> > msm_dsi ae94000.dsi: [drm:dsi_cmds2buf_tx] *ERROR* wait for video done timed out
> > dsi_cmds2buf_tx: cmd dma tx failed, type=0x5, data0=0x28, len=4, ret=-110
> > panel-visionox-rm69299 ae94000.dsi.0: sending DCS SET_DISPLAY_OFF failed: -110
> > ```
> > 
> > Signed-off-by: Guido Günther <agx@...xcpu.org>
> > ---
> >   drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > index 909c280eab1fb..e65697ce6f51c 100644
> > --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > @@ -247,7 +247,7 @@ static const struct drm_display_mode visionox_rm69299_1080x2248_60hz = {
> >   };
> >   static const struct drm_display_mode visionox_rm69299_1080x2160_60hz = {
> > -	.clock = 158695,
> > +	.clock = 149360,
> >   	.hdisplay = 1080,
> >   	.hsync_start = 1080 + 26,
> >   	.hsync_end = 1080 + 26 + 2,
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>

Thanks! I noticed I made a small mistake: the timeouts in the log were
unrelated but the clock change in itself is correct and needed to make
the panel show an actual picture. I've corrected that in the commit
message and folded the patch into more changes for the driver:

  https://lore.kernel.org/phone-devel/20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org/T/#t

Cheers,
 -- Guido