linux-kernel - Re: [PATCH v5 08/12] mm: constify arch_pick_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKPOu+-_bPwE4sCcb6n-nfi3nWy6L0gBAoHgRz3qwdUHByE_Lg@mail.gmail.com>
Date: Mon, 1 Sep 2025 17:06:18 +0200
From: Max Kellermann <max.kellermann@...os.com>
To: David Hildenbrand <david@...hat.com>
Cc: akpm@...ux-foundation.org, axelrasmussen@...gle.com, yuanchu@...gle.com, 
	willy@...radead.org, hughd@...gle.com, mhocko@...e.com, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, lorenzo.stoakes@...cle.com, 
	Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com, 
	vishal.moola@...il.com, linux@...linux.org.uk, 
	James.Bottomley@...senpartnership.com, deller@....de, agordeev@...ux.ibm.com, 
	gerald.schaefer@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, 
	borntraeger@...ux.ibm.com, svens@...ux.ibm.com, davem@...emloft.net, 
	andreas@...sler.com, dave.hansen@...ux.intel.com, luto@...nel.org, 
	peterz@...radead.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
	x86@...nel.org, hpa@...or.com, chris@...kel.net, jcmvbkbc@...il.com, 
	viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz, weixugc@...gle.com, 
	baolin.wang@...ux.alibaba.com, rientjes@...gle.com, shakeel.butt@...ux.dev, 
	thuth@...hat.com, broonie@...nel.org, osalvador@...e.de, jfalempe@...hat.com, 
	mpe@...erman.id.au, nysal@...ux.ibm.com, linux-arm-kernel@...ts.infradead.org, 
	linux-parisc@...r.kernel.org, linux-s390@...r.kernel.org, 
	sparclinux@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v5 08/12] mm: constify arch_pick_mmap_layout() for
 improved const-correctness

On Mon, Sep 1, 2025 at 3:58 PM David Hildenbrand <david@...hat.com> wrote:
> > index 2201da0afecc..0232d983b715 100644
> > --- a/include/linux/sched/mm.h
> > +++ b/include/linux/sched/mm.h
> > @@ -178,7 +178,7 @@ static inline void mm_update_next_owner(struct mm_struct *mm)
> >   #endif
> >
> >   extern void arch_pick_mmap_layout(struct mm_struct *mm,
> > -                               struct rlimit *rlim_stack);
> > +                               const struct rlimit *rlim_stack);
> >
> >   unsigned long
> >   arch_get_unmapped_area(struct file *filp, unsigned long addr,
> > @@ -211,7 +211,7 @@ generic_get_unmapped_area_topdown(struct file *filp, unsigned long addr,
> >                                 unsigned long flags, vm_flags_t vm_flags);
> >   #else
> >   static inline void arch_pick_mmap_layout(struct mm_struct *mm,
> > -                                      struct rlimit *rlim_stack) {}
> > +                                      const struct rlimit *rlim_stack) {}
> >   #endif
>
> Should both these cases also use *const?
>
> (for the latter we probably don't care either, but maybe just to be
> consistent)

Actually, it would *only* make sense on the latter, because the former
is a prototype...