linux-kernel - Re: [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250901152452.GA1114741@bhelgaas>
Date: Mon, 1 Sep 2025 10:24:52 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Mark Brown <broonie@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Cc: Inochi Amaoto <inochiama@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Marc Zyngier <maz@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Anders Roxell <anders.roxell@...aro.org>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, Longbin Li <looong.bin@...il.com>,
	Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in
 cond_[startup|shutdown]_parent()

[cc->to: Thomas]

On Mon, Sep 01, 2025 at 01:35:17PM +0100, Mark Brown wrote:
> On Wed, Aug 27, 2025 at 02:29:07PM +0800, Inochi Amaoto wrote:
> > For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT,
> > the newly added callback irq_startup() and irq_shutdown() for
> > pci_msi[x]_templete will not unmask/mask the interrupt when startup/
> > shutdown the interrupt. This will prevent the interrupt from being
> > enabled/disabled normally.
> > 
> > Add the missing check for MSI_FLAG_PCI_MSI_MASK_PARENT in the
> > cond_[startup|shutdown]_parent(). So the interrupt can be normally
> > unmasked/masked if it does not support MSI_FLAG_PCI_MSI_MASK_PARENT.
> 
> Tested-by: Mark Brown <broonie@...nel.org>
> 
> This is causing multiple platforms to fail to boot in -next, it'd be
> great if we could get it merged to fix them.

It looks like you merged 54f45a30c0d0 ("PCI/MSI: Add startup/shutdown
for per device domains"), Thomas.  I assume you'll merge this fix too?

Let me know if you'd prefer that I take it.  Looks like a candidate
for v6.17.

Bjorn