linux-kernel - Re: [PATCH] accel/rocket: Check the correct DMA irq status to warn about

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAObsKCGbS4kkYjFvQONjF7RWbzNRejCGMi1puzHnSpsR4pguA@mail.gmail.com>
Date: Mon, 1 Sep 2025 17:45:01 +0200
From: Tomeu Vizoso <tomeu@...euvizoso.net>
To: Heiko Stuebner <heiko@...ech.de>
Cc: ogabbay@...nel.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] accel/rocket: Check the correct DMA irq status to warn about

On Mon, Aug 18, 2025 at 8:56 PM Heiko Stuebner <heiko@...ech.de> wrote:
>
> Right now, the code checks the DMA_READ_ERROR state 2 times, while
> I guess it was supposed to warn about both read and write errors.
>
> Change the 2nd check to look at the write-error flag.
>
> Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>

Thanks, Heiko, you are right, I have applied it to drm-misc-next.

Regards,

Tomeu


> ---
>  drivers/accel/rocket/rocket_job.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c
> index 5d4afd692306..3440b862e749 100644
> --- a/drivers/accel/rocket/rocket_job.c
> +++ b/drivers/accel/rocket/rocket_job.c
> @@ -422,7 +422,7 @@ static irqreturn_t rocket_job_irq_handler(int irq, void *data)
>         u32 raw_status = rocket_pc_readl(core, INTERRUPT_RAW_STATUS);
>
>         WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
> -       WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
> +       WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_WRITE_ERROR);
>
>         if (!(raw_status & PC_INTERRUPT_RAW_STATUS_DPU_0 ||
>               raw_status & PC_INTERRUPT_RAW_STATUS_DPU_1))
> --
> 2.47.2
>