linux-kernel - Re: [PATCH v2] media: rzg2l-cru: csi-2: Support RZ/V2H input sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bgucngxjf337yyr6c5crnz7ee75dq47phbysspixpolyymppdc@4t7gnmkxrmdm>
Date: Mon, 1 Sep 2025 17:55:59 +0200
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Jacopo Mondi <jacopo.mondi@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil@...nel.org>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Tommaso Merciai <tommaso.merciai.xr@...renesas.com>, 
	Biju Das <biju.das.jz@...renesas.com>, Daniel Scally <dan.scally+renesas@...asonboard.com>, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Jacopo Mondi <jacopo.mondi+renesas@...asonboard.com>
Subject: Re: [PATCH v2] media: rzg2l-cru: csi-2: Support RZ/V2H input sizes

Hi Laurent

On Mon, Sep 01, 2025 at 05:29:54PM +0200, Laurent Pinchart wrote:
> On Fri, Aug 29, 2025 at 01:12:14PM +0200, Jacopo Mondi wrote:
> > From: Jacopo Mondi <jacopo.mondi+renesas@...asonboard.com>
> >
> > The CRU version on the RZ/V2H SoC supports larger input sizes
> > (4096x4096) compared to the version on the RZ/G2L (2800x4095).
> >
> > Store the per-SoC min/max sizes in the device match info and use them
> > in place of the hardcoded ones.
> >
> > While at it, use the min sizes reported by the info structure to replace
> > the RZG2L_CSI2_DEFAULT_WIDTH/HEIGHT macros.
> >
> > Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@...asonboard.com>
> > Tested-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
> > ---
>
> Spurious ---

It's b4 that should append here the content of the cover letter, which
I didn't write, mea culpa, as it would just be a repetition of the
cover message.

However this should be ignored when applying the patch ?

>
> > Signed-off-by: Jacopo Mondi <jacopo.mondi@...asonboard.com>
> > ---
> > Changes in v2:
> > - Use the size values in the rzg2l_csi2_info instea of going through
> >   macros
> > - Use min_width/min_height to initialize the format and drop
> >   RZG2L_CSI2_DEFAULT_WIDTH/HEIGHT
> > - Add Tommaso's tag
> > - Link to v1: https://lore.kernel.org/r/20250826-rzv2h-cru-sizes-v1-1-dbdfc54bba11@ideasonboard.com
> > ---
> >  .../media/platform/renesas/rzg2l-cru/rzg2l-csi2.c  | 41 ++++++++++++++--------
> >  1 file changed, 26 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> > index 1520211e74185fea3bca85f36239254f6b4651db..183598d6cf0b255f779b4398e027d626ad1f3c1b 100644
> > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> > @@ -96,13 +96,6 @@
> >
> >  #define VSRSTS_RETRIES			20
> >
> > -#define RZG2L_CSI2_MIN_WIDTH		320
> > -#define RZG2L_CSI2_MIN_HEIGHT		240
> > -#define RZG2L_CSI2_MAX_WIDTH		2800
> > -#define RZG2L_CSI2_MAX_HEIGHT		4095
> > -
> > -#define RZG2L_CSI2_DEFAULT_WIDTH	RZG2L_CSI2_MIN_WIDTH
> > -#define RZG2L_CSI2_DEFAULT_HEIGHT	RZG2L_CSI2_MIN_HEIGHT
> >  #define RZG2L_CSI2_DEFAULT_FMT		MEDIA_BUS_FMT_UYVY8_1X16
> >
> >  enum rzg2l_csi2_pads {
> > @@ -137,6 +130,10 @@ struct rzg2l_csi2_info {
> >  	int (*dphy_enable)(struct rzg2l_csi2 *csi2);
> >  	int (*dphy_disable)(struct rzg2l_csi2 *csi2);
> >  	bool has_system_clk;
> > +	unsigned int min_width;
> > +	unsigned int min_height;
> > +	unsigned int max_width;
> > +	unsigned int max_height;
> >  };
> >
> >  struct rzg2l_csi2_timings {
> > @@ -418,6 +415,10 @@ static const struct rzg2l_csi2_info rzg2l_csi2_info = {
> >  	.dphy_enable = rzg2l_csi2_dphy_enable,
> >  	.dphy_disable = rzg2l_csi2_dphy_disable,
> >  	.has_system_clk = true,
> > +	.min_width = 320,
> > +	.min_height = 240,
> > +	.max_width = 2800,
> > +	.max_height = 4095,
> >  };
> >
> >  static int rzg2l_csi2_dphy_setting(struct v4l2_subdev *sd, bool on)
> > @@ -542,6 +543,10 @@ static const struct rzg2l_csi2_info rzv2h_csi2_info = {
> >  	.dphy_enable = rzv2h_csi2_dphy_enable,
> >  	.dphy_disable = rzv2h_csi2_dphy_disable,
> >  	.has_system_clk = false,
> > +	.min_width = 320,
> > +	.min_height = 240,
>
> As the minimum for all SoCs is the same, I'd keep the MIN macros.

Unless you feel strong about this, I won't resend just for this
change.

>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>
> > +	.max_width = 4096,
> > +	.max_height = 4096,
> >  };
> >
> >  static int rzg2l_csi2_mipi_link_setting(struct v4l2_subdev *sd, bool on)
> > @@ -631,6 +636,7 @@ static int rzg2l_csi2_set_format(struct v4l2_subdev *sd,
> >  				 struct v4l2_subdev_state *state,
> >  				 struct v4l2_subdev_format *fmt)
> >  {
> > +	struct rzg2l_csi2 *csi2 = sd_to_csi2(sd);
> >  	struct v4l2_mbus_framefmt *src_format;
> >  	struct v4l2_mbus_framefmt *sink_format;
> >
> > @@ -653,9 +659,11 @@ static int rzg2l_csi2_set_format(struct v4l2_subdev *sd,
> >  	sink_format->ycbcr_enc = fmt->format.ycbcr_enc;
> >  	sink_format->quantization = fmt->format.quantization;
> >  	sink_format->width = clamp_t(u32, fmt->format.width,
> > -				     RZG2L_CSI2_MIN_WIDTH, RZG2L_CSI2_MAX_WIDTH);
> > +				     csi2->info->min_width,
> > +				     csi2->info->max_width);
> >  	sink_format->height = clamp_t(u32, fmt->format.height,
> > -				      RZG2L_CSI2_MIN_HEIGHT, RZG2L_CSI2_MAX_HEIGHT);
> > +				     csi2->info->min_height,
> > +				     csi2->info->max_height);
> >  	fmt->format = *sink_format;
> >
> >  	/* propagate format to source pad */
> > @@ -668,9 +676,10 @@ static int rzg2l_csi2_init_state(struct v4l2_subdev *sd,
> >  				 struct v4l2_subdev_state *sd_state)
> >  {
> >  	struct v4l2_subdev_format fmt = { .pad = RZG2L_CSI2_SINK, };
> > +	struct rzg2l_csi2 *csi2 = sd_to_csi2(sd);
> >
> > -	fmt.format.width = RZG2L_CSI2_DEFAULT_WIDTH;
> > -	fmt.format.height = RZG2L_CSI2_DEFAULT_HEIGHT;
> > +	fmt.format.width = csi2->info->min_width;
> > +	fmt.format.height = csi2->info->min_height;
> >  	fmt.format.field = V4L2_FIELD_NONE;
> >  	fmt.format.code = RZG2L_CSI2_DEFAULT_FMT;
> >  	fmt.format.colorspace = V4L2_COLORSPACE_SRGB;
> > @@ -697,16 +706,18 @@ static int rzg2l_csi2_enum_frame_size(struct v4l2_subdev *sd,
> >  				      struct v4l2_subdev_state *sd_state,
> >  				      struct v4l2_subdev_frame_size_enum *fse)
> >  {
> > +	struct rzg2l_csi2 *csi2 = sd_to_csi2(sd);
> > +
> >  	if (fse->index != 0)
> >  		return -EINVAL;
> >
> >  	if (!rzg2l_csi2_code_to_fmt(fse->code))
> >  		return -EINVAL;
> >
> > -	fse->min_width = RZG2L_CSI2_MIN_WIDTH;
> > -	fse->min_height = RZG2L_CSI2_MIN_HEIGHT;
> > -	fse->max_width = RZG2L_CSI2_MAX_WIDTH;
> > -	fse->max_height = RZG2L_CSI2_MAX_HEIGHT;
> > +	fse->min_width = csi2->info->min_width;
> > +	fse->min_height = csi2->info->min_height;
> > +	fse->max_width = csi2->info->max_width;
> > +	fse->max_height = csi2->info->max_height;
> >
> >  	return 0;
> >  }
> >
> > ---
> > base-commit: 16428e2449ab96cce27be6ab17b750b404c76c7c
> > change-id: 20250826-rzv2h-cru-sizes-371ff5a88081
>
> --
> Regards,
>
> Laurent Pinchart