| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250901174724.351237f0@jic23-huawei>
Date: Mon, 1 Sep 2025 17:47:24 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Mohammad Amin Hosseini <moahmmad.hosseinii@...il.com>
Cc: linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org, lars@...afoo.de,
Michael.Hennerich@...log.com, dlechner@...libre.com, nuno.sa@...log.com,
andy@...nel.org
Subject: Re: [PATCH v3] staging: iio: adc: ad7816: add mutex to serialize
SPI/GPIO operations
On Mon, 1 Sep 2025 11:07:50 +0330
Mohammad Amin Hosseini <moahmmad.hosseinii@...il.com> wrote:
> The ad7816 driver was accessing SPI and GPIO lines without
> synchronization, which could lead to race conditions when accessed
> concurrently from multiple contexts. This might result in corrupted
> readings or inconsistent GPIO states.
>
> Introduce an io_lock mutex in the driver structure to serialize:
> - SPI transactions in ad7816_spi_read() and ad7816_spi_write()
> - GPIO pin toggling sequences
Split this into two patches (but wait a few days for current discussions to
finish). Patch 1 do the SPI / GPIO groups (and use guard() as Andy pointed out).
> - Updates to device state via sysfs store functions (mode, channel, oti)
This one is less clearly required. We might get races but it's not obvious
to me that they will hurt as tends to be one writer / one reader of a
small variable. In theory the accesses might get split / torn but in practice that
doesn't happen. Anyhow, that one needs more info on why the protection
is necessary.
One other comment inline.
Jonathan
>
> The mutex ensures proper mutual exclusion and prevents race
> conditions under concurrent access.
>
> Signed-off-by: Mohammad Amin Hosseini <moahmmad.hosseinii@...il.com>
>
> ---
> Changes in v3:
> - Restore proper capitalization in From:/Signed-off-by lines
> - Move v2 changelog below the --- line
>
> Changes in v2:
> - Fixed mismatch between From: and Signed-off-by lines
> - Verified style compliance with checkpatch.pl
> ---
> drivers/staging/iio/adc/ad7816.c | 29 +++++++++++++++++++----------
> 1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
> index 4774df778de9..06567d048a6d 100644
> --- a/drivers/staging/iio/adc/ad7816.c
> +++ b/drivers/staging/iio/adc/ad7816.c
> @@ -50,6 +50,7 @@ struct ad7816_chip_info {
> u8 oti_data[AD7816_CS_MAX + 1];
> u8 channel_id; /* 0 always be temperature */
> u8 mode;
> + struct mutex io_lock; /* Protects SPI transactions and GPIO toggling */
> };
>
> enum ad7816_type {
> @@ -67,13 +68,13 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data)
> int ret;
> __be16 buf;
>
> + mutex_lock(&chip->io_lock);
> +
> gpiod_set_value(chip->rdwr_pin, 1);
> gpiod_set_value(chip->rdwr_pin, 0);
> ret = spi_write(spi_dev, &chip->channel_id, sizeof(chip->channel_id));
> - if (ret < 0) {
> - dev_err(&spi_dev->dev, "SPI channel setting error\n");
> - return ret;
> - }
> + if (ret < 0)
> + goto unlock;
> gpiod_set_value(chip->rdwr_pin, 1);
>
> if (chip->mode == AD7816_PD) { /* operating mode 2 */
> @@ -92,13 +93,13 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data)
> gpiod_set_value(chip->rdwr_pin, 0);
> gpiod_set_value(chip->rdwr_pin, 1);
> ret = spi_read(spi_dev, &buf, sizeof(*data));
> - if (ret < 0) {
> - dev_err(&spi_dev->dev, "SPI data read error\n");
> - return ret;
> - }
> + if (ret < 0)
> + goto unlock;
>
> *data = be16_to_cpu(buf);
>
> +unlock:
> + mutex_unlock(&chip->io_lock);
> return ret;
> }
>
> @@ -107,12 +108,13 @@ static int ad7816_spi_write(struct ad7816_chip_info *chip, u8 data)
> struct spi_device *spi_dev = chip->spi_dev;
> int ret;
>
> + mutex_lock(&chip->io_lock);
> +
> gpiod_set_value(chip->rdwr_pin, 1);
> gpiod_set_value(chip->rdwr_pin, 0);
> ret = spi_write(spi_dev, &data, sizeof(data));
> - if (ret < 0)
> - dev_err(&spi_dev->dev, "SPI oti data write error\n");
>
> + mutex_unlock(&chip->io_lock);
> return ret;
> }
>
> @@ -136,6 +138,7 @@ static ssize_t ad7816_store_mode(struct device *dev,
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ad7816_chip_info *chip = iio_priv(indio_dev);
>
> + mutex_lock(&chip->io_lock);
> if (strcmp(buf, "full") == 0) {
> gpiod_set_value(chip->rdwr_pin, 1);
> chip->mode = AD7816_FULL;
> @@ -143,6 +146,7 @@ static ssize_t ad7816_store_mode(struct device *dev,
> gpiod_set_value(chip->rdwr_pin, 0);
> chip->mode = AD7816_PD;
> }
> + mutex_unlock(&chip->io_lock);
>
> return len;
> }
> @@ -200,7 +204,9 @@ static ssize_t ad7816_store_channel(struct device *dev,
> return -EINVAL;
> }
>
> + mutex_lock(&chip->io_lock);
> chip->channel_id = data;
> + mutex_unlock(&chip->io_lock);
>
> return len;
> }
> @@ -322,7 +328,9 @@ static inline ssize_t ad7816_set_oti(struct device *dev,
> if (ret)
> return -EIO;
>
> + mutex_lock(&chip->io_lock);
> chip->oti_data[chip->channel_id] = data;
> + mutex_unlock(&chip->io_lock);
>
> return len;
> }
> @@ -363,6 +371,7 @@ static int ad7816_probe(struct spi_device *spi_dev)
> dev_set_drvdata(&spi_dev->dev, indio_dev);
>
> chip->spi_dev = spi_dev;
> + mutex_init(&chip->io_lock);
For new mutex prefer
ret = devm_mutex_init();
if (ret)
return ret;
The advantage this brings for very particular log debugging cases isn't
huge, but it is also not remotely costly to do this (in new code,
I don't want the churn of mass updates!)
> for (i = 0; i <= AD7816_CS_MAX; i++)
> chip->oti_data[i] = 203;
>
Powered by blists - more mailing lists