linux-kernel - Re: [PATCH 3/4] gpio: imx-rpmsg: add imx-rpmsg GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB91859E0AACFBC1FC913019848907A@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date: Mon, 1 Sep 2025 17:22:47 +0000
From: Shenwei Wang <shenwei.wang@....com>
To: Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>, Linus Walleij
	<linus.walleij@...aro.org>, Bjorn Andersson <andersson@...nel.org>, Mathieu
 Poirier <mathieu.poirier@...aro.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Bartosz Golaszewski <brgl@...ev.pl>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, Peng Fan <peng.fan@....com>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 3/4] gpio: imx-rpmsg: add imx-rpmsg GPIO driver



> -----Original Message-----
> From: Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
> Sent: Monday, September 1, 2025 2:27 AM
> To: Linus Walleij <linus.walleij@...aro.org>; Shenwei Wang
> <shenwei.wang@....com>; Bjorn Andersson <andersson@...nel.org>; Mathieu
> Poirier <mathieu.poirier@...aro.org>
> Cc: Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>;
> Conor Dooley <conor+dt@...nel.org>; Shawn Guo <shawnguo@...nel.org>;
> Sascha Hauer <s.hauer@...gutronix.de>; Bartosz Golaszewski <brgl@...ev.pl>;
> Pengutronix Kernel Team <kernel@...gutronix.de>; Fabio Estevam
> <festevam@...il.com>; Peng Fan <peng.fan@....com>; linux-
> remoteproc@...r.kernel.org; devicetree@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>
> Subject: [EXT] Re: [PATCH 3/4] gpio: imx-rpmsg: add imx-rpmsg GPIO driver
> 
> 
> Hello,
> 
> On 8/21/25 11:01, Linus Walleij wrote:
> > Hi Shenwei,
> >
> > thanks for your patch!
> >
> > On Mon, Aug 18, 2025 at 10:45 PM Shenwei Wang <shenwei.wang@....com>
> wrote:
> >
> >> On i.MX SoCs, the system may include two processors:
> >>          - An MCU running an RTOS
> >>          - An MPU running Linux
> >>
> >> These processors communicate via the RPMSG protocol.
> >> The driver implements the standard GPIO interface, allowing the Linux
> >> side to control GPIO controllers which reside in the remote processor
> >> via RPMSG protocol.
> >>
> >> Signed-off-by: Shenwei Wang <shenwei.wang@....com>
> > Since this is a first RPMSG GPIO driver, I'd like if Björn and/or
> > Mathieu have a look at it so I'm sure it is RPMSG-proper!
> 
> Could this driver be generic (platform independent) ?
> Perhaps i missed something, but it seems to me that there is no IMX specific
> code.
> Making it generic would allow other platforms to reuse it instead of duplicating it.
> 

The driver uses the RPMSG channel just as a transport layer, so the implementation is actually
platform-independent. However, it requires the remote side to implement the same communication 
protocol and behavior for the GPIO controller.

Thanks,
Shenwei

> Thanks,
> Arnaud
> 
> >
> >> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> >> a437fe652dbc..2ce4e9b5225e 100644
> >> --- a/drivers/gpio/Kconfig
> >> +++ b/drivers/gpio/Kconfig
> >> @@ -402,6 +402,17 @@ config GPIO_ICH
> >>
> >>            If unsure, say N.
> >>
> >> +config GPIO_IMX_RPMSG
> >> +       tristate "NXP i.MX SoC RPMSG GPIO support"
> >> +       depends on IMX_REMOTEPROC && RPMSG && GPIOLIB
> >> +       default IMX_REMOTEPROC
> >> +       help
> >> +         Say yes here to support the RPMSG GPIO functions on i.MX SoC based
> >> +         platform.  Currently supported devices: i.MX7ULP, i.MX8ULP, i.MX8x,
> >> +         and i.MX9x.
> >> +
> >> +         If unsure, say N.