linux-kernel - Re: [PATCH] net: mvpp2: Fix refcount leak in mvpp2_use_acpi_compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250901125047.4c909ace@kernel.org>
Date: Mon, 1 Sep 2025 12:50:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Miaoqian Lin <linmq006@...il.com>
Cc: Marcin Wojtas <marcin.s.wojtas@...il.com>, Russell King
 <linux@...linux.org.uk>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mvpp2: Fix refcount leak in
 mvpp2_use_acpi_compat_mode

On Sat, 30 Aug 2025 17:18:54 +0800 Miaoqian Lin wrote:
> -	return (!fwnode_property_present(port_fwnode, "phy-handle") &&
> -		!fwnode_property_present(port_fwnode, "managed") &&
> -		!fwnode_get_named_child_node(port_fwnode, "fixed-link"));
> +	if (fwnode_property_present(port_fwnode, "phy-handle") ||
> +	    fwnode_property_present(port_fwnode, "managed"))
> +		return false;
> +
> +	fixed_link = fwnode_get_named_child_node(port_fwnode, "fixed-link");

Wouldn't it be easier to switch to fwnode_get_named_child_node_count() ?
-- 
pw-bot: cr