[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aLYDl1lyL1jLMw8c@stanley.mountain>
Date: Mon, 1 Sep 2025 23:35:35 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Frank Li <Frank.li@....com>
Cc: Srinivas Kandagatla <srini@...nel.org>,
NXP S32 Linux Team <s32@....com>, linaro-s32@...aro.org,
linux-kernel@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH V2 2/3] nvmem: s32g-ocotp: Add driver for S32G OCOTP
On Wed, Aug 27, 2025 at 12:34:11PM -0400, Frank Li wrote:
> > +static int s32g_ocotp_read(void *context, unsigned int offset,
> > + void *val, size_t bytes)
> > +{
> > + struct s32g_ocotp_priv *s32g_data = context;
> > + u32 *dst = val;
> > +
> > + while (bytes >= sizeof(u32)) {
> > + *dst++ = ioread32(s32g_data->base + offset);
> > +
> > + bytes -= sizeof(u32);
> > + offset += sizeof(u32);
> > + }
>
> readsw() ?
>
Hi Frank,
I've learned a lot from your reviews. Thanks. :) It would be readsl()
since it's a u32. But readsl() doesn't increment the offset, it just
reads from the same memory address over and over.
I've made all the other changes.
regards,
dan carpenter
Powered by blists - more mailing lists