linux-kernel - Re: [PATCH 0/2] vfio/platform: Deprecate vfio-amba and reset drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLYYvURhjGmJ__Fx@google.com>
Date: Mon, 1 Sep 2025 22:05:49 +0000
From: Pranjal Shrivastava <praan@...gle.com>
To: Alex Williamson <alex.williamson@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	eric.auger@...hat.com, smostafa@...gle.com
Subject: Re: [PATCH 0/2] vfio/platform: Deprecate vfio-amba and reset drivers

On Mon, Aug 25, 2025 at 11:57:59AM -0600, Alex Williamson wrote:
> Based on discussion[1] there's still interest in keeping vfio-platform
> itself, but the use case doesn't involve any of the current reset
> drivers and doesn't include vfio-amba.  To give any users a chance to
> speak up, let's mark these as deprecated and generate logs if they're
> used.
> 
> I intend to pull the vfio/fsl-mc removal from the previous series given
> there were no objections.  Thanks,
> 
> Alex
> 
> [1] https://lore.kernel.org/all/20250806170314.3768750-1-alex.williamson@redhat.com/
> 
> Alex Williamson (2):
>   vfio/amba: Mark for removal
>   vfio/platform: Mark reset drivers for removal
> 
>  drivers/vfio/platform/Kconfig                            | 5 ++++-
>  drivers/vfio/platform/reset/Kconfig                      | 6 +++---
>  drivers/vfio/platform/reset/vfio_platform_amdxgbe.c      | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c    | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 ++
>  drivers/vfio/platform/vfio_amba.c                        | 2 ++
>  6 files changed, 15 insertions(+), 4 deletions(-)
> 

The series feels like a sensible compromise. The rationale for
deprecating vfio-amba and the obsolete reset drivers is sound, as it
cleans up code that can no longer be tested by the maintainers [1].

The changes to Kconfig and the addition of dev_err_once() handle this
deprecation cleanly.

For the series:
Reviewed-by: Pranjal Shrivastava <praan@...gle.com>

Thanks,
Praan

[1] https://kvm-forum.qemu.org/2024/vfio-platform-kvm-forum24-landscape_TtZ3SnC.pdf

> -- 
> 2.50.1
>