linux-kernel - Re: [PATCH v2] cpufreq/longhaul: handle NULL policy in longhaul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250901052044.qtjcd5q2ycch2n6c@vireshk-i7>
Date: Mon, 1 Sep 2025 10:50:44 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Dennis Beier <nanovim@...il.com>
Cc: rafael@...nel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq/longhaul: handle NULL policy in longhaul_exit

On 30-08-25, 16:43, Dennis Beier wrote:
> longhaul_exit() was calling cpufreq_cpu_get(0) without checking
> for a NULL policy pointer. On some systems, this could lead to a
> NULL dereference and a kernel warning or panic.
> 
> This patch adds a check using unlikely() and returns early if the
> policy is NULL.
> 
> Bugzilla: #219962
> 
> Signed-off-by: Dennis Beier <nanovim@...il.com>
> ---
>  drivers/cpufreq/longhaul.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
> index ba0e08c8486a..49e76b44468a 100644
> --- a/drivers/cpufreq/longhaul.c
> +++ b/drivers/cpufreq/longhaul.c
> @@ -953,6 +953,9 @@ static void __exit longhaul_exit(void)
>  	struct cpufreq_policy *policy = cpufreq_cpu_get(0);
>  	int i;
>  
> +	if (unlikely(!policy))
> +		return;
> +
>  	for (i = 0; i < numscales; i++) {
>  		if (mults[i] == maxmult) {
>  			struct cpufreq_freqs freqs;

Applied. Thanks.

-- 
viresh