linux-kernel - RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <093601dc1ae0$2389c460$6a9d4d20$@samsung.com>
Date: Mon, 1 Sep 2025 10:31:28 +0900
From: "DooHyun Hwang" <dh0421.hwang@...sung.com>
To: "'Bart Van Assche'" <bvanassche@....org>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <alim.akhtar@...sung.com>,
	<avri.altman@....com>, <James.Bottomley@...senPartnership.com>,
	<martin.petersen@...cle.com>, <peter.wang@...iatek.com>,
	<manivannan.sadhasivam@...aro.org>, <quic_mnaresh@...cinc.com>
Cc: <grant.jung@...sung.com>, <jt77.jang@...sung.com>,
	<junwoo80.lee@...sung.com>, <jangsub.yi@...sung.com>,
	<sh043.lee@...sung.com>, <cw9316.lee@...sung.com>,
	<sh8267.baek@...sung.com>, <wkon.kim@...sung.com>
Subject: RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs
 cmd error

On 8/29/25 8:15 PM, Bart Van Assche wrote:
> On 4/16/25 7:34 PM, DooHyun Hwang wrote:
> > +	EM(UFS_CMD_ERR,		"req_complete_err")		\
> 
> Does UFS_CMD_ERR stand for "command error" or "completion error"? Please
> make the enum label and the text that is displayed in error messages
> consistent.
> 
> Bart.

UFS_CMD_ERR stands for "completion error".
The enum is converted to a string in the trace log according
to the definition below.

in include/trace/events/ufs.h
#define UFS_CMD_TRACE_STRINGS					\
	EM(UFS_CMD_SEND,	"send_req")			\
	EM(UFS_CMD_COMP,	"complete_rsp")			\
+	EM(UFS_CMD_ERR,		"req_complete_err")		\
	EM(UFS_DEV_COMP,	"dev_complete")			\
	EM(UFS_QUERY_SEND,	"query_send")			\
	EM(UFS_QUERY_COMP,	"query_complete")		\
	EM(UFS_QUERY_ERR,	"query_complete_err")		\
	EM(UFS_TM_SEND,		"tm_send")			\
	EM(UFS_TM_COMP,		"tm_complete")			\
	EMe(UFS_TM_ERR,		"tm_complete_err")

Thank you.
DooHyun Hwang.