linux-kernel - Re: [PATCH v1] usb: storage: sddr09: move write buffers into info struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025090126-gully-tarnish-43f1@gregkh>
Date: Mon, 1 Sep 2025 07:37:49 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	usb-storage@...ts.one-eyed-alien.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] usb: storage: sddr09: move write buffers into info
 struct

On Sun, Aug 31, 2025 at 12:22:47PM -0700, Alex Tran wrote:
> Changelog:

No need for that line here, right?

> - Moved allocation of buffers ('blockbuffer', 'buffer') in 
>   'sddr09_write_data' into info struct and freeing into 
>   'sddr09_card_info_destructor' so that the operations are only 
>   performed once.

Trailing spaces :(

> - 'buffer' length is now size of a full block instead of being 
>   dependent on sectors.

But why are you doing any of this?

Please take a look at the kernel documentation for how to write a good
changelog text.

And do you have this device to test that your changes here work
properly?

thanks,

greg k-h