lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250901061630.rddeuz7yclmxl6w3@DEN-DL-M31836.microchip.com>
Date: Mon, 1 Sep 2025 08:16:30 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Kory Maincent <kory.maincent@...tlin.com>
CC: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <richardcochran@...il.com>,
	<Parthiban.Veerasooran@...rochip.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v5 1/2] net: phy: micrel: Introduce function
 __lan8814_ptp_probe_once

The 08/29/2025 16:33, Kory Maincent wrote:
> 
> On Fri, 29 Aug 2025 15:48:35 +0200
> Horatiu Vultur <horatiu.vultur@...rochip.com> wrote:
> 
> > Introduce the function __lan8814_ptp_probe_once as this function will be
> > used also by lan8842 driver. This change doesn't have any functional
> > changes.
> 
> It would have been nice to add the fact that the lan8842 has a different number
> GPIO in the commit message. It would have explained more the why.

Yes, I will update this in the next version.
Thanks.

> 
> Reviewed-by: Kory Maincent <kory.maincent@...tlin.com>
> 
> Thank you!
> 
> --
> Köry Maincent, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com

-- 
/Horatiu

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ