[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<PN3P287MB18298FB93EDC498572742B2A8B07A@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
Date: Mon, 1 Sep 2025 06:44:46 +0000
From: Tarang Raval <tarang.raval@...iconsignals.io>
To: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
"sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>
CC: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>, Mauro Carvalho
Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Hans
Verkuil <hverkuil@...all.nl>, Ricardo Ribalda <ribalda@...omium.org>, Bryan
O'Donoghue <bryan.odonoghue@...aro.org>, André Apitzsch
<git@...tzsch.eu>, Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
Benjamin Mugnier <benjamin.mugnier@...s.st.com>, Matthias Fend
<matthias.fend@...end.at>, Dongcheng Yan <dongcheng.yan@...el.com>, Sylvain
Petinot <sylvain.petinot@...s.st.com>, Arnd Bergmann <arnd@...db.de>, Andy
Shevchenko <andriy.shevchenko@...ux.intel.com>, Hans de Goede
<hansg@...nel.org>, Jingjing Xiong <jingjing.xiong@...el.com>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 2/2] media: i2c: add ov2735 image sensor driver
Hi Hardev, Sakari
> Add a v4l2 subdevice driver for the Omnivision OV2735 sensor.
>
> The Omnivision OV2735 is a 1/2.7-Inch CMOS image sensor with an
> active array size of 1920 x 1080.
>
> The following features are supported:
> - Manual exposure an gain control support
> - vblank/hblank control support
> - Test pattern support control
> - Supported resolution: 1920 x 1080 @ 30fps (SGRBG10)
>
> Co-developed-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
> ---
> MAINTAINERS | 1 +
> drivers/media/i2c/Kconfig | 10 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov2735.c | 1109 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 1121 insertions(+)
> create mode 100644 drivers/media/i2c/ov2735.c
...
> +static int ov2735_enum_mbus_code(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_mbus_code_enum *code)
> +{
> + if (code->index >= 0)
Hardev, I believe this condition is always true.
You should write:
if (code->index > 0)
Sakari, Could you please remove the equals sign when you apply the patch?
> + return -EINVAL;
> +
> + code->code = MEDIA_BUS_FMT_SGRBG10_1X10;
> +
> + return 0;
> +}
...
> +static const struct of_device_id ov2735_id[] = {
> + { .compatible = "ovti,ov2735" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, ov2735_id);
> +
> +static struct i2c_driver ov2735_driver = {
> + .driver = {
> + .name = "ov2735",
> + .pm = pm_ptr(&ov2735_pm_ops),
> + .of_match_table = ov2735_id,
> + },
> + .probe = ov2735_probe,
> + .remove = ov2735_remove,
> +};
> +module_i2c_driver(ov2735_driver);
> +
> +MODULE_DESCRIPTION("OV2735 Camera Sensor Driver");
> +MODULE_AUTHOR("Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>");
> +MODULE_AUTHOR("Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>");
> +MODULE_LICENSE("GPL");
> --
> 2.34.1
Best Regards,
Tarang
Powered by blists - more mailing lists