linux-kernel - Re: [PATCH v2 net-next] ipv6: annotate data-races around devconf->rpl_seg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <879f09d3-1984-4de5-8eb5-7209c1cbf196@huawei.com>
Date: Mon, 1 Sep 2025 15:15:01 +0800
From: Yue Haibing <yuehaibing@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <horms@...nel.org>, <kuniyu@...gle.com>,
	<alex.aring@...il.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] ipv6: annotate data-races around
 devconf->rpl_seg_enabled

On 2025/8/30 10:27, Jakub Kicinski wrote:
> On Wed, 27 Aug 2025 16:12:43 +0800 Yue Haibing wrote:
>> Also initializes extra1 and extra2 to SYSCTL_ZERO and SYSCTL_ONE
>> respectively to avoid negative value writes, which may lead to
>> unexpected results in ipv6_rpl_srh_rcv().
> 
> By unexpected results you mean that min() is intended to return 0
> when either value is zero, but if one of the values is negative it
> will in fact return non-zero?

Yes，this is exact.
> 
> That's a fair point, but I'm not sure whether we should be sending
> that up as a fix. It's more of a sanity check that prevents
> unintentional misconfiguration.. Please split this patch into two
> separate ones, and send the minmax one without a Fixes tag.
> Please include more of the explanation I have provided in the first
> paragraph in the commit message, "unexpected results" is too vague
> by itself.
Ok, thanks, will split and resend with this.
>