lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250901072635d908c251@mail.local>
Date: Mon, 1 Sep 2025 09:26:35 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: kernel test robot <lkp@...el.com>
Cc: Jorge Marques <jorge.marques@...log.com>, llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Frank Li <Frank.Li@....com>
Subject: Re: drivers/i3c/master/../internals.h:53:9: error: passing 'const
 void *' to parameter of type 'void *' discards qualifiers

Hello,

On 01/09/2025 14:25:03+0800, kernel test robot wrote:
> Hi Jorge,
> 
> FYI, the error/warning still remains.

The issue is not in the i3c code but in the sparc64 code.

> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   b320789d6883cc00ac78ce83bccbfe7ed58afcf0
> commit: c20d3fa7049144f519b21616e6020e6939822145 i3c: master: cdns: Use i3c_writel_fifo() and i3c_readl_fifo()
> date:   5 weeks ago
> config: sparc64-randconfig-001-20250901 (https://download.01.org/0day-ci/archive/20250901/202509011442.yweEPWw4-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250901/202509011442.yweEPWw4-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509011442.yweEPWw4-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/i3c/master/i3c-master-cdns.c:26:
> >> drivers/i3c/master/../internals.h:53:9: error: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>       53 |         readsl(addr, buf, nbytes / 4);
>          |                ^~~~
>    arch/sparc/include/asm/io_64.h:265:41: note: passing argument to parameter 'port' here
>      265 | static inline void readsl(void __iomem *port, void *buf, unsigned long count)
>          |                                         ^
>    1 error generated.
> 
> 
> vim +53 drivers/i3c/master/../internals.h
> 
> 733b439375b494 Jorge Marques 2025-06-24  43  
> 733b439375b494 Jorge Marques 2025-06-24  44  /**
> 733b439375b494 Jorge Marques 2025-06-24  45   * i3c_readl_fifo - Read data buffer from 32bit FIFO
> 733b439375b494 Jorge Marques 2025-06-24  46   * @addr: FIFO Address to read from
> 733b439375b494 Jorge Marques 2025-06-24  47   * @buf: Pointer to the buffer to store read bytes
> 733b439375b494 Jorge Marques 2025-06-24  48   * @nbytes: Number of bytes to read
> 733b439375b494 Jorge Marques 2025-06-24  49   */
> 733b439375b494 Jorge Marques 2025-06-24  50  static inline void i3c_readl_fifo(const void __iomem *addr, void *buf,
> 733b439375b494 Jorge Marques 2025-06-24  51  				  int nbytes)
> 733b439375b494 Jorge Marques 2025-06-24  52  {
> 733b439375b494 Jorge Marques 2025-06-24 @53  	readsl(addr, buf, nbytes / 4);
> 733b439375b494 Jorge Marques 2025-06-24  54  	if (nbytes & 3) {
> 733b439375b494 Jorge Marques 2025-06-24  55  		u32 tmp;
> 733b439375b494 Jorge Marques 2025-06-24  56  
> 733b439375b494 Jorge Marques 2025-06-24  57  		tmp = readl(addr);
> 733b439375b494 Jorge Marques 2025-06-24  58  		memcpy(buf + (nbytes & ~3), &tmp, nbytes & 3);
> 733b439375b494 Jorge Marques 2025-06-24  59  	}
> 733b439375b494 Jorge Marques 2025-06-24  60  }
> 733b439375b494 Jorge Marques 2025-06-24  61  
> 
> :::::: The code at line 53 was first introduced by commit
> :::::: 733b439375b494e8a6950ab47d18a4b615b73cb3 i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()
> 
> :::::: TO: Jorge Marques <jorge.marques@...log.com>
> :::::: CC: Alexandre Belloni <alexandre.belloni@...tlin.com>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ