linux-kernel - Re: [PATCH] arm64: mm: Fix CFI failure due to kpti_ng_pgd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca30a6f6-f636-4d6f-9ec6-d6e02ef70852@arm.com>
Date: Mon, 1 Sep 2025 09:33:31 +0200
From: Kevin Brodsky <kevin.brodsky@....com>
To: Mark Rutland <mark.rutland@....com>, Kees Cook <kees@...nel.org>
Cc: Ard Biesheuvel <ardb@...nel.org>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Oliver Upton <oliver.upton@...ux.dev>,
 Anshuman Khandual <anshuman.khandual@....com>,
 Yue Haibing <yuehaibing@...wei.com>, Marc Zyngier <maz@...nel.org>,
 Mark Brown <broonie@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 Ryan Roberts <ryan.roberts@....com>,
 Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
 Joey Gouly <joey.gouly@....com>, Yeoreum Yun <yeoreum.yun@....com>,
 James Morse <james.morse@....com>,
 Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 Andrew Morton <akpm@...ux-foundation.org>,
 David Hildenbrand <david@...hat.com>,
 Zhenhua Huang <quic_zhenhuah@...cinc.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Dev Jain <dev.jain@....com>,
 Yicong Yang <yangyicong@...ilicon.com>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] arm64: mm: Fix CFI failure due to kpti_ng_pgd_alloc
 function signature

On 29/08/2025 18:06, Mark Rutland wrote:
> The actual fix looks fine, though I suspect we should move more of this
> logic into mmu.c.

Agreed, I'll look into that. Having two separate declarations in
cpufeature.c and mmu.c is ugly and leads to the kind of mistake that I made.

The fix looks perfectly fine FWIW - not adding my Reviewed-by as I saw
Catalin took v2 already :)

- Kevin