linux-kernel - Re: [PATCH v2] arm64: mm: Fix CFI failure due to kpti_ng_pgd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f6e36f1-c942-40d6-8a46-63f3ba0d0d84@arm.com>
Date: Mon, 1 Sep 2025 09:40:06 +0200
From: Kevin Brodsky <kevin.brodsky@....com>
To: David Hildenbrand <david@...hat.com>, Kees Cook <kees@...nel.org>
Cc: Ard Biesheuvel <ardb@...nel.org>, Ryan Roberts <ryan.roberts@....com>,
 Mark Rutland <mark.rutland@....com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Anshuman Khandual <anshuman.khandual@....com>,
 Oliver Upton <oliver.upton@...ux.dev>, Yue Haibing <yuehaibing@...wei.com>,
 Marc Zyngier <maz@...nel.org>, Mark Brown <broonie@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 linux-arm-kernel@...ts.infradead.org, Joey Gouly <joey.gouly@....com>,
 Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
 Yeoreum Yun <yeoreum.yun@....com>, James Morse <james.morse@....com>,
 Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 Zhenhua Huang <quic_zhenhuah@...cinc.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Dev Jain <dev.jain@....com>,
 Yicong Yang <yangyicong@...ilicon.com>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] arm64: mm: Fix CFI failure due to kpti_ng_pgd_alloc
 function signature

On 29/08/2025 21:13, David Hildenbrand wrote:
>> [...]
>>
>> diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h
>> index 6e8aa8e72601..49f1a810df16 100644
>> --- a/arch/arm64/include/asm/mmu.h
>> +++ b/arch/arm64/include/asm/mmu.h
>> @@ -17,6 +17,13 @@
>>   #include <linux/refcount.h>
>>   #include <asm/cpufeature.h>
>>   +enum pgtable_type {
>> +    TABLE_PTE, m68k_table_types
>> +    TABLE_PMD,
>> +    TABLE_PUD,
>> +    TABLE_P4D,
>> +};
>
> Just noting that we now have "enum pgtable_level" in
> include/linux/pgtable.h that could at some point possibly be used here
> instead (not in this fix). 

Thanks for the heads-up! I'll look into using the new generic enum
instead, there's really no need for every architecture to invent its
own. m68k could also use it instead of m68k_table_types.

- Kevin