lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKPOu+9CiT-5P--6TZcyq=jHLDhCa8LDh1AYjKr69+0shO8UrQ@mail.gmail.com>
Date: Mon, 1 Sep 2025 10:26:24 +0200
From: Max Kellermann <max.kellermann@...os.com>
To: David Hildenbrand <david@...hat.com>
Cc: Kiryl Shutsemau <kirill@...temov.name>, akpm@...ux-foundation.org, 
	axelrasmussen@...gle.com, yuanchu@...gle.com, willy@...radead.org, 
	hughd@...gle.com, mhocko@...e.com, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, 
	vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com, vishal.moola@...il.com
Subject: Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer parameters

On Mon, Sep 1, 2025 at 10:20 AM David Hildenbrand <david@...hat.com> wrote:
>
> On 01.09.25 10:05, Max Kellermann wrote:
> > On Mon, Sep 1, 2025 at 9:33 AM Kiryl Shutsemau <kirill@...temov.name> wrote:
> >>
> >> On Sun, Aug 31, 2025 at 11:39:07AM +0200, Max Kellermann wrote:
> >>> For improved const-correctness.
> >>
> >> It is not a proper commit message.
> >
> > I believe it is proper for something as trivial as this. I think
> > adding more text would just be noise, only wasting the time of people
> > reading it. But that is a matter of perspective: I expect every
> > competent C developer to know the concept of const-correctness.
> >
> > Do you believe the commit message of 29cfe7556bfd ("mm: constify more
> > page/folio tests") is "proper"?
> >
>
> "Constify shmem related test functions for improved const-correctness."

Mentioning "shmem" adds no information because that is already
mentioned in the subject. "Constify" is just as redundant, it's the
same as "adding const".

The only new piece of information here is "test". If you want, I can
change the subject to "mm/shmem: add `const` to pointer parameters of
test functions" and leave the body. Would that make the commit message
"proper", or do you insist on having redundant information in the
body?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ