linux-kernel - Re: [PATCH] powerpc/83xx: Add a null pointer check to mcu_gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23d79af2-8509-4037-80fd-34ef1ce507d2@cs-soprasteria.com>
Date: Mon, 1 Sep 2025 08:59:16 +0000
From: LEROY Christophe <christophe.leroy2@...soprasteria.com>
To: Kunwu Chan <chentao@...inos.cn>, "mpe@...erman.id.au"
	<mpe@...erman.id.au>, "npiggin@...il.com" <npiggin@...il.com>,
	"aneesh.kumar@...nel.org" <aneesh.kumar@...nel.org>,
	"naveen.n.rao@...ux.ibm.com" <naveen.n.rao@...ux.ibm.com>,
	"maddy@...ux.ibm.com" <maddy@...ux.ibm.com>
CC: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Kunwu Chan
	<kunwu.chan@...mail.com>
Subject: Re: [PATCH] powerpc/83xx: Add a null pointer check to
 mcu_gpiochip_add



Le 15/01/2024 à 10:43, Kunwu Chan a écrit :
> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
> 
> Cc: Kunwu Chan <kunwu.chan@...mail.com>
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
> index 4d8fa9ed1a67..d1ae66eaa687 100644
> --- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
> +++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
> @@ -120,6 +120,8 @@ static int mcu_gpiochip_add(struct mcu *mcu)
>   
>   	gc->owner = THIS_MODULE;
>   	gc->label = kasprintf(GFP_KERNEL, "%pfw", dev_fwnode(dev));
> +	if (!gc->label)
> +		return -ENOMEM;
>   	gc->can_sleep = 1;
>   	gc->ngpio = MCU_NUM_GPIO;
>   	gc->base = -1;