linux-kernel - Re: [PATCH 2/3] cdns3: Remove unused tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250901023235.GB2344733@nchen-desktop>
Date: Mon, 1 Sep 2025 10:32:35 +0800
From: "Peter Chen (CIX)" <peter.chen@...nel.org>
To: Steven Rostedt <rostedt@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pawel Laszczak <pawell@...ence.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/3] cdns3: Remove unused tracepoints

On 25-08-28 21:55:54, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> Tracepoints that are defined take up around 5K each, even if they are not
> used. If they are defined and not used, then they waste memory for unused
> code. Soon unused tracepoints will cause warnings.
> 
> Remove the unused tracepoints of the cdns3 subsystem. They are:
> cdns3_mapped_request
> cdns3_map_request
> cdns3_stream_transfer_split
> cdns3_stream_transfer_split_next_part
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Acked-by: Peter Chen <peter.chen@...nel.org>

Peter
> ---
>  drivers/usb/cdns3/cdns3-trace.h | 61 ---------------------------------
>  1 file changed, 61 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdns3-trace.h b/drivers/usb/cdns3/cdns3-trace.h
> index c4e542f1b9b7..21a6a2ce7a3d 100644
> --- a/drivers/usb/cdns3/cdns3-trace.h
> +++ b/drivers/usb/cdns3/cdns3-trace.h
> @@ -283,39 +283,6 @@ TRACE_EVENT(cdns3_ep0_queue,
>  		  __entry->length)
>  );
>  
> -DECLARE_EVENT_CLASS(cdns3_stream_split_transfer_len,
> -	TP_PROTO(struct cdns3_request *req),
> -	TP_ARGS(req),
> -	TP_STRUCT__entry(
> -		__string(name, req->priv_ep->name)
> -		__field(struct cdns3_request *, req)
> -		__field(unsigned int, length)
> -		__field(unsigned int, actual)
> -		__field(unsigned int, stream_id)
> -	),
> -	TP_fast_assign(
> -		__assign_str(name);
> -		__entry->req = req;
> -		__entry->actual = req->request.length;
> -		__entry->length = req->request.actual;
> -		__entry->stream_id = req->request.stream_id;
> -	),
> -	TP_printk("%s: req: %p,request length: %u actual length: %u  SID: %u",
> -		  __get_str(name), __entry->req, __entry->length,
> -		  __entry->actual, __entry->stream_id)
> -);
> -
> -DEFINE_EVENT(cdns3_stream_split_transfer_len, cdns3_stream_transfer_split,
> -	     TP_PROTO(struct cdns3_request *req),
> -	     TP_ARGS(req)
> -);
> -
> -DEFINE_EVENT(cdns3_stream_split_transfer_len,
> -	     cdns3_stream_transfer_split_next_part,
> -	     TP_PROTO(struct cdns3_request *req),
> -	     TP_ARGS(req)
> -);
> -
>  DECLARE_EVENT_CLASS(cdns3_log_aligned_request,
>  	TP_PROTO(struct cdns3_request *priv_req),
>  	TP_ARGS(priv_req),
> @@ -354,34 +321,6 @@ DEFINE_EVENT(cdns3_log_aligned_request, cdns3_prepare_aligned_request,
>  	TP_ARGS(req)
>  );
>  
> -DECLARE_EVENT_CLASS(cdns3_log_map_request,
> -	TP_PROTO(struct cdns3_request *priv_req),
> -	TP_ARGS(priv_req),
> -	TP_STRUCT__entry(
> -		__string(name, priv_req->priv_ep->name)
> -		__field(struct usb_request *, req)
> -		__field(void *, buf)
> -		__field(dma_addr_t, dma)
> -	),
> -	TP_fast_assign(
> -		__assign_str(name);
> -		__entry->req = &priv_req->request;
> -		__entry->buf = priv_req->request.buf;
> -		__entry->dma = priv_req->request.dma;
> -	),
> -	TP_printk("%s: req: %p, req buf %p, dma %p",
> -		  __get_str(name), __entry->req, __entry->buf, &__entry->dma
> -	)
> -);
> -DEFINE_EVENT(cdns3_log_map_request, cdns3_map_request,
> -	     TP_PROTO(struct cdns3_request *req),
> -	     TP_ARGS(req)
> -);
> -DEFINE_EVENT(cdns3_log_map_request, cdns3_mapped_request,
> -	     TP_PROTO(struct cdns3_request *req),
> -	     TP_ARGS(req)
> -);
> -
>  DECLARE_EVENT_CLASS(cdns3_log_trb,
>  	TP_PROTO(struct cdns3_endpoint *priv_ep, struct cdns3_trb *trb),
>  	TP_ARGS(priv_ep, trb),
> -- 
> 2.50.1
> 
> 

-- 

Best regards,
Peter