linux-kernel - Re: [PATCH v3 8/9] media: qcom: camss: Add support for VFE 690

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af4eba15-ea0c-4c56-9b0c-b53454ee5926@quicinc.com>
Date: Mon, 1 Sep 2025 15:26:21 +0530
From: Vikram Sharma <quic_vikramsa@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <andersson@...nel.org>,
        <konradybcio@...nel.org>, <hverkuil-cisco@...all.nl>,
        <cros-qcom-dts-watchers@...omium.org>, <catalin.marinas@....com>,
        <will@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <quic_svankada@...cinc.com>,
        <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 8/9] media: qcom: camss: Add support for VFE 690


On 9/1/2025 2:34 PM, Bryan O'Donoghue wrote:
> On 03/07/2025 18:19, Vikram Sharma wrote:
>> +        !strcmp(clock->name, "camnoc_axi"));
>
> This is causing a regression on other platforms because they define 
> camnnoc_axi but not @ the rate of the pixel clock.
>
> In fact its not very obvious why the CAMNOC AXI would want to have a 
> pixel clock applied to the interconnect fabric.
>
> The following resolves the regression for me. I can either merge with 
> this change or I'll have to drop the VFE690 changes until you come 
> back with something else.
Hi Bryan,

updating camnoc axi to 400Mhz was required for TPG test case.
As of now you can Merge VFE patch with below change.

Meanwhile I will work on an alternative approach to set camnoc_axi and 
submit as a separate patch.

>
> ➜ deckard@...ittarius-a  ~/Development/qualcomm/qlt-kernel 
> git:(aaa8b5ab704f3) ✗ git diff
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c 
> b/drivers/media/platform/qcom/camss/camss-vfe.c
> index e969de74818f1..1aa0ba5ad8d60 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -913,8 +913,7 @@ static int vfe_match_clock_names(struct vfe_device 
> *vfe,
>
>         return (!strcmp(clock->name, vfe_name) ||
>                 !strcmp(clock->name, vfe_lite_name) ||
> -               !strcmp(clock->name, "vfe_lite") ||
> -               !strcmp(clock->name, "camnoc_axi"));
> +               !strcmp(clock->name, "vfe_lite"));
>
> ---
> bod

Best regards,

Vikram

>