linux-kernel - Re: [PATCH v5 5/6] drm/bridge: cadence: cdns-mhdp8546-core: Reduce log level for DPCD read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2dd50da1-eb33-4d91-9bfc-224160f1e947@ideasonboard.com>
Date: Mon, 1 Sep 2025 13:08:33 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Harikrishna Shenoy <h-shenoy@...com>
Cc: jonas@...boo.se, jernej.skrabec@...il.com,
 maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de, airlied@...il.com,
 simona@...ll.ch, lyude@...hat.com, luca.ceresoli@...tlin.com,
 viro@...iv.linux.org.uk, andy.yan@...k-chips.com, linux@...blig.org,
 javierm@...hat.com, linux-kernel@...r.kernel.org, devarsht@...com,
 j-choudhary@...com, u-kumar1@...com, s-jain1@...com,
 andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, mripard@...nel.org, lumag@...nel.org,
 dianders@...omium.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v5 5/6] drm/bridge: cadence: cdns-mhdp8546-core: Reduce
 log level for DPCD read/write

Hi,

On 11/08/2025 10:59, Harikrishna Shenoy wrote:
> From: Jayesh Choudhary <j-choudhary@...com>
> 
> Reduce the log level for cdns_mhdp_dpcd_read and cdns_mhdp_dpcd_write
> errors in cdns_mhdp_transfer function as in case of failure, there is
> flooding of these prints along with other indicators like EDID failure
> logs which are fairly intuitive in themselves rendering these error logs
> useless.
> Also, the caller functions for the cdns_mhdp_transfer in drm_dp_helper.c
> (which calls it 32 times), has debug log level in case transfer fails.
> So having a superseding log level in cdns_mhdp_transfer seems bad.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> ---
>  drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> index 47c657237c37..4fb1db3e030c 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> @@ -778,7 +778,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux,
>  			if (!ret)
>  				continue;
>  
> -			dev_err(mhdp->dev,
> +			dev_dbg(mhdp->dev,
>  				"Failed to write DPCD addr %u\n",
>  				msg->address + i);
>  
> @@ -788,7 +788,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux,
>  		ret = cdns_mhdp_dpcd_read(mhdp, msg->address,
>  					  msg->buffer, msg->size);
>  		if (ret) {
> -			dev_err(mhdp->dev,
> +			dev_dbg(mhdp->dev,
>  				"Failed to read DPCD addr %u\n",
>  				msg->address);
>  

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

 Tomi