linux-kernel - Re: [PATCH v1] arm64: dts: renesas: r8a779g0: Add new gsx node for V4H

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXDW5=UCVRSq2DBks++YpyoJ9rtsdaKheYLv7foEZmg-A@mail.gmail.com>
Date: Mon, 1 Sep 2025 12:24:07 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Anh Nguyen <anh.nguyen.pv@...esas.com>
Cc: "magnus.damm" <magnus.damm@...il.com>, "robh@...nel.org" <robh@...nel.org>, 
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, 
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, Duy Dang <duy.dang.yw@...esas.com>, 
	Duy Nguyen <duy.nguyen.rh@...esas.com>
Subject: Re: [PATCH v1] arm64: dts: renesas: r8a779g0: Add new gsx node for V4H

Hi Anh,

On Mon, 25 Aug 2025 at 06:37, Anh Nguyen <anh.nguyen.pv@...esas.com> wrote:
> From 8a8391bc4ceaac5248267851b71c9cce6b5c434a Mon Sep 17 00:00:00 2001
> From: Anh Nguyen <anh.nguyen.pv@...esas.com>
> Date: Thu, 21 Aug 2025 10:01:30 +0700
> Subject: [PATCH 2/2] arm64: dts: renesas: r8a779g0: Add new gsx node for V4H SoC
>
> Add new gsx node to enable GPU for V4H SoC
>
> Signed-off-by: Anh Nguyen <anh.nguyen.pv@...esas.com>
> Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> @@ -2121,6 +2121,15 @@ gic: interrupt-controller@...00000 {
>                         interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> +               gsx: gsx@...00000 {
> +                       compatible = "renesas,gsx";

This compatible value is not documented.  However, I don't think this
can be used as-is.  I think the property should look like:

    compatible = "renesas,r8a779g0-gpu", "img,img-axm-8-256".

The first step would be to add it to the DT bindings in
Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml.
Furthermore, support for this variant should be added to the driver
under drivers/gpu/drm/imagination/.
And where to get the firmware required to operate the GPU?

> +                       reg = <0 0xfd000000 0 0x800000>;
> +                       interrupts = <GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>;

According to the documentation, there are 8 interrupts?

> +                       clocks = <&cpg CPG_MOD 0>;
> +                       power-domains = <&sysc R8A779G0_PD_A23DGB>;
> +                       resets = <&cpg 0>;
> +               };
> +
>                 csi40: csi2@...00000 {
>                         compatible = "renesas,r8a779g0-csi2";
>                         reg = <0 0xfe500000 0 0x40000>;

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds