linux-kernel - Re: [PATCH v2] ASoC: codecs: tlv320dac33: switch to gpiod api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7de59d85-a72e-4afa-b3d7-8729e22f4c3f@sirena.org.uk>
Date: Mon, 1 Sep 2025 11:35:35 +0100
From: Mark Brown <broonie@...nel.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: lgirdwood@...il.com, tiwai@...e.com, perex@...ex.cz,
	shenghao-ding@...com, kevin-lu@...com, baojun.xu@...com,
	linus.walleij@...aro.org, brgl@...ev.pl,
	linux-sound@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: tlv320dac33: switch to gpiod api

On Sun, Aug 31, 2025 at 08:59:56PM -0700, Alex Tran wrote:
> Changelog:
> - Changed reset GPIO setup that uses 'gpio_request' and
>   'gpio_direction_output' to use 'devm_gpio_request_one' instead 
>   for legacy support.
> - Convert to gpio descriptor for use.
> - Better error handling with 'gpiod_set_value'.
> - Removed cleanup of reset gpio as gpiod api is now used.
> 
> 
> - Performed full conversion to gpiod with 'devm_gpiod_get_optional'.
> - Removed struct 'tlv320dac33_platform_data' as it is
>   not used in the kernel.
> - Removed file 'tlv320dac33-plat.h' as it was not included
>   anywhere outside this driver.
> - Removed 'power_gpio' and added 'reset_gpiod'.
> - Added default value for dac33->burst_bclkdiv as it can't be 0 (2-17).
>   See <https://www.ti.com/lit/ds/symlink/tlv320dac32.pdf>

This is a set of separate changes which as covered in
submitting-patches.rst should each be split into individual patches,
this makes things much easier to review.

As also covered in submitting-patches.rst any inter-version changelogs
should go after the --- so they can be removed by tooling.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)