[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <93b9e1dc-f8d5-4b8d-a7d2-27ba8e09dd54@ghiti.fr>
Date: Mon, 1 Sep 2025 12:41:13 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Xiaolei Wang <xiaolei.wang@...driver.com>,
dmitry.baryshkov@....qualcomm.com, maarten.lankhorst@...ux.intel.com,
mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
jani.nikula@...el.com, ville.syrjala@...ux.intel.com
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/tests: modeset: Add drm connector
atomic_[duplicate/destroy]_state
Hi Xiaolei,
On 8/27/25 10:45, Xiaolei Wang wrote:
> Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers")
> added the atomic state path, so adding the drm connector
> atomic_[duplicate/destroy]_state is also necessary.
>
> WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0
> Call trace:
> drm_connector_init_only+0x934/0xee0 (P)
> drmm_connector_init+0xe0/0x1b0
> drm_client_modeset_test_init+0x290/0x534
> kunit_try_run_case+0x110/0x3b4
> kunit_generic_run_threadfn_adapter+0x80/0xec
> kthread+0x3b8/0x6c0
> ret_from_fork+0x10/0x20
>
> Fixes: 66671944e176 ("drm/tests: helpers: Add atomic helpers")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>
> Reviewed-by: Maxime Ripard <mripard@...nel.org>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>
> v1: https://patchew.org/linux/20250811063403.98739-1-xiaolei.wang@windriver.com/
>
> v2: compared with v1, add Fixes tag
>
> drivers/gpu/drm/tests/drm_client_modeset_test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/tests/drm_client_modeset_test.c b/drivers/gpu/drm/tests/drm_client_modeset_test.c
> index 3f44fe5e92e4..e702a27c2368 100644
> --- a/drivers/gpu/drm/tests/drm_client_modeset_test.c
> +++ b/drivers/gpu/drm/tests/drm_client_modeset_test.c
> @@ -12,6 +12,7 @@
> #include <drm/drm_modes.h>
> #include <drm/drm_modeset_helper_vtables.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_atomic_state_helper.h>
>
> struct drm_client_modeset_test_priv {
> struct drm_device *drm;
> @@ -48,6 +49,9 @@ static const struct drm_connector_helper_funcs drm_client_modeset_connector_help
> };
>
> static const struct drm_connector_funcs drm_client_modeset_connector_funcs = {
> + .reset = drm_atomic_helper_connector_reset,
> + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
> + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
> };
>
> static int drm_client_modeset_test_init(struct kunit *test)
Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>
Thanks,
Alex
Powered by blists - more mailing lists