linux-kernel - Re: [PATCH] staging: octeon: use fixed-width integer types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLV6lF2gutK24RtV@stanley.mountain>
Date: Mon, 1 Sep 2025 13:51:00 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Osama Abdelkader <osama.abdelkader@...il.com>
Cc: gregkh@...uxfoundation.org, aleksander.lobakin@...el.com,
	sergio.paracuellos@...il.com, pabeni@...hat.com,
	abhishektamboli9@...il.com, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: octeon: use fixed-width integer types

On Fri, Aug 29, 2025 at 10:01:07PM +0200, Osama Abdelkader wrote:
> The kernel coding style prefers fixed-width integer types defined in
> <linux/types.h> (u8, u16, u32, u64, etc.) over the C99 stdint.h types
> (e.g. uint64_t).
> 
> Replace uint64_t with u64, uint32_t with u32, uint16_t with u16
> uint8_t with u8 in octeon-stubs.h.
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>
> ---
>  drivers/staging/octeon/octeon-stubs.h | 1745 +++++++++++++------------
>  1 file changed, 873 insertions(+), 872 deletions(-)
> 
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 44cced319c11..ff6509b28cdd 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -43,144 +43,144 @@
>  #define CVMX_POW_WQ_INT_PC		0
>  
>  union cvmx_pip_wqe_word2 {
> -	uint64_t u64;
> +	u64 u64;

This was already done upstream so the patch doesn't apply.

The point of the octeon-stubs.h file is it allows us to compile test
a bunch of code which is specific to Octeon.  The real code lives
in arch/mips/include/asm/octeon/cvmx-wqe.h.  These files have diverged
quite a bit, unfortunately.  But I guess everything still builds...
I don't know if it's really useful to cleanup this fake code while
leaving the real code as-is.


> @@ -1380,12 +1380,13 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interfac
>  	return r;
>  }
>  
> -static inline void cvmx_pko_send_packet_prepare(uint64_t port, uint64_t queue,
> +static inline void cvmx_pko_send_packet_prepare(u64 port, u64 queue,
>  						cvmx_pko_lock_t use_locking)
>  { }
>  
> -static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(uint64_t port,
> -		uint64_t queue, union cvmx_pko_command_word0 pko_command,
> +static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(u64 port,
> +							    u64 queue,
> +								union cvmx_pko_command_word0 cmd,
>  		union cvmx_buf_ptr packet, cvmx_pko_lock_t use_locking)

This is messed up now.  Just leave the indenting as it was and fix it in
another change if you want to.

regards,
dan carpenter