linux-kernel - Re: [PATCH v8 15/15] arm64: dts: cix: Enable PCIe on the Orion O6 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <011b1e32-10e6-460a-bb9d-95235d926ed6@cixtech.com>
Date: Mon, 1 Sep 2025 11:14:54 +0800
From: Hans Zhang <hans.zhang@...tech.com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 robh@...nel.org, kwilczynski@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, mpillai@...ence.com, fugang.duan@...tech.com,
 guoyin.chen@...tech.com, peter.chen@...tech.com,
 cix-kernel-upstream@...tech.com, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 15/15] arm64: dts: cix: Enable PCIe on the Orion O6
 board

On 2025/8/30 21:33, Manivannan Sadhasivam wrote:
> [Some people who received this message don't often get email from mani@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> On Tue, Aug 19, 2025 at 07:52:39PM GMT, hans.zhang@...tech.com wrote:
>> From: Hans Zhang <hans.zhang@...tech.com>
>>
>> Add PCIe RC support on Orion O6 board.
>>
> 
> So with this patch (and dependencies), the endpoints are detected and usable?
> Any limitation with not supporting the GPIO and pinctrl should be documented in
> the description.
> 

Dear Mani,

Thank you very much for your reply.

We can rely on the initialization of bios. After the GPIO and pinctrl 
are upstream later, we will add them in.

Just as I described in the change log of the cover letter, we can 
enumerate devices normally and use the network normally.

Just as the first version of this driver also did not have GPIO, 
pinctrl. Moreover, Arnd also suggested that we could separate the upstream.
drivers/pci/controller/dwc/pcie-amd-mdb.c

This is the situation of running the latest linux kernel on our O6 board.
root@...-localhost:~# uname -a
Linux cix-localhost 6.17.0-rc4-00015-g5aaae89e41ab #203 SMP PREEMPT Mon 
Sep  1 10:54:16 CST 2025 aarch64 GNU/Linux
root@...-localhost:~# lspci
0000:c0:00.0 PCI bridge: Device 1f6c:0001
0000:c1:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 
8126 (rev 01)
0001:90:00.0 PCI bridge: Device 1f6c:0001
0001:91:00.0 Non-Volatile memory controller: Samsung Electronics Co Ltd 
NVMe SSD Controller S4LV008[Pascal]
0002:60:00.0 PCI bridge: Device 1f6c:0001
0002:61:00.0 Network controller: Realtek Semiconductor Co., Ltd. 
RTL8852BE PCIe 802.11ax Wireless Network Controller
0003:00:00.0 PCI bridge: Device 1f6c:0001
0003:01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 
8126 (rev 01)
0004:30:00.0 PCI bridge: Device 1f6c:0001
0004:31:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 
8126 (rev 01)

Best regards,
Hans

> - Mani
> 
>> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
>> ---
>> Dear Krzysztof,
>>
>> Due to the fact that the GPIO, PINCTRL and other modules of our platform are
>> not yet ready for upstream. Attributes that PCIe depends on, such as reset-gpios
>> and pinctrl*, have not been added for the time being. It will be added gradually
>> in the future.
>>
>> The following are Arnd's previous comments. We can go to upsteam separately.
>> https://lore.kernel.org/all/422deb4d-db29-48c1-b0c9-7915951df500@app.fastmail.com/
>> ---
>>   arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/cix/sky1-orion-o6.dts b/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
>> index d74964d53c3b..be3ec4f5d11e 100644
>> --- a/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
>> +++ b/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
>> @@ -34,6 +34,26 @@ linux,cma {
>>
>>   };
>>
>> +&pcie_x8_rc {
>> +     status = "okay";
>> +};
>> +
>> +&pcie_x4_rc {
>> +     status = "okay";
>> +};
>> +
>> +&pcie_x2_rc {
>> +     status = "okay";
>> +};
>> +
>> +&pcie_x1_0_rc {
>> +     status = "okay";
>> +};
>> +
>> +&pcie_x1_1_rc {
>> +     status = "okay";
>> +};
>> +
>>   &uart2 {
>>        status = "okay";
>>   };
>> --
>> 2.49.0
>>
> 
> --
> மணிவண்ணன் சதாசிவம்