linux-kernel - Re: [PATCH] LoongArch: replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H4pVgYOQy-qEfTtpVb9bjY7VOeJkjWYBWRGVpSnoh=upQ@mail.gmail.com>
Date: Tue, 2 Sep 2025 20:25:22 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: cuitao <cuitao@...inos.cn>
Cc: loongarch@...ts.linux.dev, kernel@...0n.name, jiaxun.yang@...goat.com, 
	linmq006@...il.com, ziyao@...root.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: replace sprintf() with sysfs_emit()

Queued, thanks.

Huacai

On Tue, Sep 2, 2025 at 5:04 PM cuitao <cuitao@...inos.cn> wrote:
>
> As Documentation/filesystems/sysfs.rst suggested, show() should only use
> sysfs_emit() or sysfs_emit_at() when formatting the value to be returned
> to user space.
>
> No functional change intended.
>
> Signed-off-by: cuitao <cuitao@...inos.cn>
> ---
>  arch/loongarch/kernel/env.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/env.c b/arch/loongarch/kernel/env.c
> index c0a5dc9aeae2..19e30206b6e7 100644
> --- a/arch/loongarch/kernel/env.c
> +++ b/arch/loongarch/kernel/env.c
> @@ -86,7 +86,7 @@ late_initcall(fdt_cpu_clk_init);
>  static ssize_t boardinfo_show(struct kobject *kobj,
>                               struct kobj_attribute *attr, char *buf)
>  {
> -       return sprintf(buf,
> +       return sysfs_emit(buf,
>                 "BIOS Information\n"
>                 "Vendor\t\t\t: %s\n"
>                 "Version\t\t\t: %s\n"
> --
> 2.33.0
>
>