linux-kernel - Re: [PATCH v4 07/10] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5424 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbc9baa3-041d-4018-a23a-aa428fdcb45c@quicinc.com>
Date: Tue, 2 Sep 2025 20:58:43 +0800
From: Luo Jie <quic_luoj@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        "Varadarajan
 Narayanan" <quic_varada@...cinc.com>,
        Georgi Djakov <djakov@...nel.org>, "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Anusha Rao <quic_anusha@...cinc.com>,
        "Manikanta Mylavarapu" <quic_mmanikan@...cinc.com>,
        Devi Priya
	<quic_devipriy@...cinc.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Richard
 Cochran" <richardcochran@...il.com>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <quic_kkumarcs@...cinc.com>, <quic_linchen@...cinc.com>,
        <quic_leiwei@...cinc.com>, <quic_pavir@...cinc.com>,
        <quic_suruchia@...cinc.com>
Subject: Re: [PATCH v4 07/10] dt-bindings: clock: qcom: Add NSS clock
 controller for IPQ5424 SoC



On 8/29/2025 3:38 PM, Krzysztof Kozlowski wrote:
> On Thu, Aug 28, 2025 at 06:32:20PM +0800, Luo Jie wrote:
>> NSS clock controller provides the clocks and resets to the networking
>> blocks such as PPE (Packet Process Engine) and UNIPHY (PCS) on IPQ5424
>> devices.
>>
>> Add support for the compatible string "qcom,ipq5424-nsscc" based on the
>> existing IPQ9574 NSS clock controller Device Tree binding. Additionally,
>> update the clock names for PPE and NSS for newer SoC additions like
>> IPQ5424 to use generic and reusable identifiers "nss" and "ppe" without
>> the clock rate suffix.
>>
>> Also add master/slave ids for IPQ5424 networking interfaces, which is
>> used by nss-ipq5424 driver for providing interconnect services using
>> icc-clk framework.
>>
>> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>
>> ---
>>   .../bindings/clock/qcom,ipq9574-nsscc.yaml         | 62 ++++++++++++++++++---
>>   include/dt-bindings/clock/qcom,ipq5424-nsscc.h     | 65 ++++++++++++++++++++++
>>   include/dt-bindings/interconnect/qcom,ipq5424.h    | 13 +++++
>>   include/dt-bindings/reset/qcom,ipq5424-nsscc.h     | 46 +++++++++++++++
>>   4 files changed, 178 insertions(+), 8 deletions(-)
> 
> 
> Are you going to change the binding in next version?
> 

As discussed in response to the comments in IPQ9574 bindings file, I am
not planning to change the binding itself in the next version.

> Best regards,
> Krzysztof
>