linux-kernel - Re: [PATCH v2 1/3] irqchip/sg2042-msi: Set irq type according to DT configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7m10zk0.ffs@tglx>
Date: Tue, 02 Sep 2025 15:11:27 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Chen Wang <unicornxw@...il.com>, u.kleine-koenig@...libre.com,
 aou@...s.berkeley.edu, unicorn_wang@...look.com, conor+dt@...nel.org,
 inochiama@...il.com, krzk+dt@...nel.org, looong.bin@...il.com,
 palmer@...belt.com, paul.walmsley@...ive.com, robh@...nel.org,
 sycamoremoon376@...il.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 sophgo@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] irqchip/sg2042-msi: Set irq type according to DT
 configuration

On Tue, Aug 26 2025 at 09:09, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@...look.com>
>
> The original MSI interrupt type was hard-coded, which was not a good idea.

That's not really helpful, unless you explain WHY it's not a good
idea...

Also for correctness sake, you want to change the DTs first and not
after you changed the driver to read it from the stale device tree with
the wrong type.

Thanks,

        tglx