linux-kernel - Re: [PATCH][next] ASoC: SOF: Intel: hda-stream: Fix incorrect variable used in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec553d4f-169c-4173-8fa8-281ed3a147d8@linux.intel.com>
Date: Tue, 2 Sep 2025 16:17:26 +0300
From: Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To: Colin Ian King <colin.i.king@...il.com>,
 Liam Girdwood <lgirdwood@...il.com>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
 Daniel Baluta <daniel.baluta@....com>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Keyon Jie <yang.jie@...ux.intel.com>,
 sound-open-firmware@...a-project.org, linux-sound@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ASoC: SOF: Intel: hda-stream: Fix incorrect
 variable used in error message



On 02/09/2025 15:06, Colin Ian King wrote:
> The dev_err message is reporting an error about capture streams however
> it is using the incorrect variable num_playback instead of num_capture.
> Fix this by using the correct variable num_capture.
> 
> Fixes: a1d1e266b445 ("ASoC: SOF: Intel: Add Intel specific HDA stream operations")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>

> ---
>  sound/soc/sof/intel/hda-stream.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/intel/hda-stream.c b/sound/soc/sof/intel/hda-stream.c
> index aa6b0247d5c9..a34f472ef175 100644
> --- a/sound/soc/sof/intel/hda-stream.c
> +++ b/sound/soc/sof/intel/hda-stream.c
> @@ -890,7 +890,7 @@ int hda_dsp_stream_init(struct snd_sof_dev *sdev)
>  
>  	if (num_capture >= SOF_HDA_CAPTURE_STREAMS) {
>  		dev_err(sdev->dev, "error: too many capture streams %d\n",
> -			num_playback);
> +			num_capture);
>  		return -EINVAL;
>  	}
>  

-- 
Péter