linux-kernel - [PATCH 4/6] scsi: megaraid_sas: Remove redundant ternary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250902132359.83059-5-liaoyuanhong@vivo.com>
Date: Tue,  2 Sep 2025 21:23:44 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: Kashyap Desai <kashyap.desai@...adcom.com>,
	Sumit Saxena <sumit.saxena@...adcom.com>,
	Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
	Chandrakanth patil <chandrakanth.patil@...adcom.com>,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	megaraidlinux.pdl@...adcom.com (open list:MEGARAID SCSI/SAS DRIVERS),
	linux-scsi@...r.kernel.org (open list:MEGARAID SCSI/SAS DRIVERS),
	linux-kernel@...r.kernel.org (open list)
Cc: Liao Yuanhong <liaoyuanhong@...o.com>
Subject: [PATCH 4/6] scsi: megaraid_sas: Remove redundant ternary operators

Remove redundant ternary operators to clean up the code.

Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c   | 4 ++--
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 615e06fd4ee8..25589ade8409 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -2097,7 +2097,7 @@ static int megasas_sdev_configure(struct scsi_device *sdev,
 	if ((instance->tgt_prop) && (instance->nvme_page_size))
 		ret_target_prop = megasas_get_target_prop(instance, sdev);
 
-	is_target_prop = (ret_target_prop == DCMD_SUCCESS) ? true : false;
+	is_target_prop = ret_target_prop == DCMD_SUCCESS;
 	megasas_set_static_target_properties(sdev, lim, is_target_prop);
 
 	/* This sdev property may change post OCR */
@@ -3448,7 +3448,7 @@ enable_sdev_max_qd_store(struct device *cdev,
 
 	shost_for_each_device(sdev, shost) {
 		ret_target_prop = megasas_get_target_prop(instance, sdev);
-		is_target_prop = (ret_target_prop == DCMD_SUCCESS) ? true : false;
+		is_target_prop = ret_target_prop == DCMD_SUCCESS;
 		megasas_set_fw_assisted_qd(sdev, is_target_prop);
 	}
 	mutex_unlock(&instance->reset_mutex);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index a6794f49e9fa..cd9fea07e563 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2835,7 +2835,7 @@ megasas_build_ldio_fusion(struct megasas_instance *instance,
 	} else {
 		if (MR_BuildRaidContext(instance, &io_info, rctx,
 					local_map_ptr, &raidLUN))
-			fp_possible = (io_info.fpOkForIo > 0) ? true : false;
+			fp_possible = io_info.fpOkForIo > 0;
 	}
 
 	megasas_get_msix_index(instance, scp, cmd, io_info.data_arms);
@@ -5121,7 +5121,7 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
 				    (instance->nvme_page_size))
 					ret_target_prop = megasas_get_target_prop(instance, sdev);
 
-				is_target_prop = (ret_target_prop == DCMD_SUCCESS) ? true : false;
+				is_target_prop = ret_target_prop == DCMD_SUCCESS;
 				megasas_set_dynamic_target_properties(sdev, NULL,
 						is_target_prop);
 			}
-- 
2.34.1