[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250902134417-GYA1155728@gentoo.org>
Date: Tue, 2 Sep 2025 21:44:17 +0800
From: Yixun Lan <dlan@...too.org>
To: Vivian Wang <wangruikang@...as.ac.cn>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
Alex Elder <elder@...cstar.com>, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] riscv: dts: spacemit: uart: remove sec_uart1 device
node
Hi Vivian,
On 20:55 Tue 02 Sep , Vivian Wang wrote:
>
> On 9/2/25 20:26, Yixun Lan wrote:
> > [...]
> >
> > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> > index abde8bb07c95c5a745736a2dd6f0c0e0d7c696e4..3094f75ed13badfc3db333be2b3195c61f57fddf 100644
> > --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> > @@ -777,16 +777,7 @@ uart9: serial@...17800 {
> > status = "disabled";
> > };
> >
> > - sec_uart1: serial@...12000 {
> > - compatible = "spacemit,k1-uart",
> > - "intel,xscale-uart";
> > - reg = <0x0 0xf0612000 0x0 0x100>;
> > - interrupts = <43>;
> > - clock-frequency = <14857000>;
> > - reg-shift = <2>;
> > - reg-io-width = <4>;
> > - status = "reserved"; /* for TEE usage */
> > - };
> > + /* sec_uart1: 0xf0612000, not available from Linux */
>
> I know this is going back and forth a lot but I don't think that's a
> good description of what's going on.
>
> My preference is that we just drop this node altogether, just forgetting
> that this thing even exists. But if you do think we want to keep the
yes, removing the comment and completely dropping it is an option..
> information we can drop the clock-frequency property too and change its
> status to something like:
>
> status = "disabled"; /* No clock defined */
>
> Which also silences the warning - disabled nodes are allowed to be
> incomplete.
no, set to 'disabled' is simply wrong, it doesn't reflect the meaning of
"unavaiable", I remembered we've rejected this before introducing the
'sec_uart1' node in the first place
>
> My personal opinion is that I think sec_uart1 and TEE support feels too
> theoretical to be worth caring about.
>
> Vivian "dramforever" Wang
>
--
Yixun Lan (dlan)
Powered by blists - more mailing lists