linux-kernel - Re: [PATCH 11/29] drm/crtc: Drop no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3ccf01a-9584-4224-8846-fb8352240467@suse.de>
Date: Tue, 2 Sep 2025 15:45:48 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Maxime Ripard <mripard@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Jyri Sarha <jyri.sarha@....fi>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Devarsh Thakkar <devarsht@...com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/29] drm/crtc: Drop no_vblank bit field



Am 02.09.25 um 10:32 schrieb Maxime Ripard:
> The no_vblank field in drm_crtc_state is defined as a bit-field with a
> single bit.
>
> This will create a syntax issue with the macros we'll introduce next,
> and most other booleans but the *_changed ones in drm_crtc_state do not
> use a bit field anyway.
>
> Let's drop it.
>
> Signed-off-by: Maxime Ripard <mripard@...nel.org>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   include/drm/drm_crtc.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index c462bd9b2f7d3ae08e669463717002e5f78122fe..11e3299cfad1572c6e507918c7cceae7a28ba4cf 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -184,11 +184,11 @@ struct drm_crtc_state {
>   	 * &drm_crtc_state.no_blank == true is valid and usually used when the
>   	 * writeback connector attached to the CRTC has a new job queued. In
>   	 * this case the driver will send the VBLANK event on its own when the
>   	 * writeback job is complete.
>   	 */
> -	bool no_vblank : 1;
> +	bool no_vblank;
>   
>   	/**
>   	 * @plane_mask: Bitmask of drm_plane_mask(plane) of planes attached to
>   	 * this CRTC.
>   	 */
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)