linux-kernel - Re: [PATCH 12/21] mfd: arizona: make legacy gpiolib interface optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5a683d99-b323-4ab7-bf0a-e91436ffd301@app.fastmail.com>
Date: Tue, 02 Sep 2025 15:47:48 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Lee Jones" <lee@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Bartosz Golaszewski" <brgl@...ev.pl>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 "Liam Girdwood" <lgirdwood@...il.com>, "Mark Brown" <broonie@...nel.org>,
 "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>,
 "Jiri Slaby" <jirislaby@...nel.org>,
 "Sakari Ailus" <sakari.ailus@...ux.intel.com>,
 "Charles Keepax" <ckeepax@...nsource.cirrus.com>,
 patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH 12/21] mfd: arizona: make legacy gpiolib interface optional

On Tue, Sep 2, 2025, at 14:44, Lee Jones wrote:
> On Fri, 08 Aug 2025, Arnd Bergmann wrote:
>
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The only machine that still uses the old gpio number based interface
>> is the wlf_cragg_6410 board file. In order to remove the dependency
>> on the interfaces, add #ifdef blocks here.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/mfd/arizona-irq.c         |  5 ++++-
>>  include/linux/mfd/arizona/pdata.h |  6 ++++++
>>  sound/soc/codecs/arizona-jack.c   | 17 ++++++++++++++++-
>>  3 files changed, 26 insertions(+), 2 deletions(-)
>
> Just FTR, I hate this!   =:-D

Any alternative suggestions?

Would you be happier with a hard "depends on GPIOLIB_LEGACY"?

I see only two in-tree users other than the old 6410 board
that use the modern path: exynos5433-tm2-common.dtsi
and drivers/platform/x86/x86-android-tablets/lenovo.c.

Making those platforms 'select GPIOLIB_LEGACY' is technically
incorrect since they don't need the legayc interfaces, but it
would be a temporary workaround until wlf_cragg_6410 is
gone.

     Arnd