linux-kernel - Re: [PATCH] tick: Remove unreasonable detached state set in tick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLb4bBqWscIt7Wi2@localhost.localdomain>
Date: Tue, 2 Sep 2025 16:00:12 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Bibo Mao <maobibo@...ngson.cn>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tick: Remove unreasonable detached state set in
 tick_shutdown()

Le Mon, Aug 11, 2025 at 11:57:20AM +0800, Bibo Mao a écrit :
> Hi,
> 
> Previously tick_shutdown() is called in BP, percpu timer cannot be shutdown
> in BP. Now it is called in AP, percpu timer can be shutdown in AP itself.

Ok, one more reason for not backporting it to stable then.

> 
> And there is another method, like other architectures add hotplug event
> callbak to shutdown percpu timer such as CPUHP_AP_LOONGARCH_TIMER_STARTING.
> 
> Which one do you prefer?

I prefer your fix that works for every clockevents. We want the active clockevent
to be stopped by the time we reach CPUHP_AP_OFFLINE.

If you add a loongarch hotplug callback, it must be for architecture
specifics.

Thanks.

-- 
Frederic Weisbecker
SUSE Labs