linux-kernel - Re: [PATCH] platform/x86/amd/pmc: Add Stellaris Slim Gen6 AMD to spurious 8042 quirks list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3830aeee-91d7-48ee-b67e-8aefbbd2124e@kernel.org>
Date: Tue, 2 Sep 2025 09:15:07 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Werner Sembach <wse@...edocomputers.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>, Hans de Goede
 <hansg@...nel.org>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>
Cc: Christoffer Sandberg <cs@...edo.de>, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/amd/pmc: Add Stellaris Slim Gen6 AMD to
 spurious 8042 quirks list

On 9/1/2025 11:42 AM, Werner Sembach wrote:
> From: Christoffer Sandberg <cs@...edo.de>
> 
> Prevents instant wakeup ~1s after suspend
> 
> Signed-off-by: Christoffer Sandberg <cs@...edo.de>
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> ---
>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> index 7ffc659b27944..8b8944483b859 100644
> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> @@ -248,6 +248,13 @@ static const struct dmi_system_id fwbug_list[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "Lafite Pro V 14M"),
>   		}
>   	},
> +	{
> +		.ident = "TUXEDO Stellaris Slim 15 AMD Gen6",
> +		.driver_data = &quirk_spurious_8042,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "GMxHGxx"),
> +		}
> +	},
>   	{}
>   };
>   

FYI - this seems to conflict with other changes on review-ilpo-fixes and 
fixes branches.

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/drivers/platform/x86/amd/pmc/pmc-quirks.c?h=review-ilpo-fixes&id=c96f86217bb28e019403bb8f59eacd8ad5a7ad1a

Also - a few other comments.

1) Do you have line of sight to a firmware (BIOS or EC) fix?  If so; it 
would be better to specify a specific firmware release that is affected.

2) Shouldn't you also have DMI_SYS_VENDOR or some other matching keys 
else set?  Or is it really all these boards with this specific name?