linux-kernel - Re: [PATCH 3/4] reset: th1520: Support reset controllers in more subsystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM7P189MB100965809B3DE48A90A15415E306A@AM7P189MB1009.EURP189.PROD.OUTLOOK.COM>
Date: Tue, 2 Sep 2025 16:15:08 +0200
From: Maud Spierings <maud_spierings@...mail.com>
To: ziyao@...root.org
Cc: alex@...ti.fr, aou@...s.berkeley.edu, conor+dt@...nel.org,
 devicetree@...r.kernel.org, fustini@...nel.org, gaohan@...as.ac.cn,
 guoren@...nel.org, krzk+dt@...nel.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, m.wilczynski@...sung.com,
 p.zabel@...gutronix.de, palmer@...belt.com, paul.walmsley@...ive.com,
 rabenda.cn@...il.com, robh@...nel.org, uwu@...nowy.me, wefu@...hat.com
Subject: Re: [PATCH 3/4] reset: th1520: Support reset controllers in more
 subsystems

Hi Yao,

> Introduce reset controllers for AP, MISC, VI, VP and DSP subsystems and
> add their reset signal mappings.
> 
> Signed-off-by: Yao Zi <ziyao@...root.org>
> ---

/* snip */

>  static const struct of_device_id th1520_reset_match[] = {
> +	{ .compatible = "thead,th1520-reset-ap", .data = &th1520_ap_reset_data },
> +	{ .compatible = "thead,th1520-reset-misc", .data = &th1520_misc_reset_data },
> +	{ .compatible = "thead,th1520-reset-vi", .data = &th1520_vi_reset_data },
>  	{ .compatible = "thead,th1520-reset", .data = &th1520_reset_data },
> +	{ .compatible = "thead,th1520-reset-vp", .data = &th1520_vp_reset_data },
> +	{ .compatible = "thead,th1520-reset-dsp", .data = &th1520_dsp_reset_data },

I believe these should be alphabetically sorted on compatible name.

>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, th1520_reset_match);
> -- 
> 2.50.1

Kind regards,
Maud